]> git.ipfire.org Git - thirdparty/git.git/commitdiff
refs: remove old refs_warn_dangling_symref
authorPhil Hord <phil.hord@gmail.com>
Mon, 23 Jun 2025 23:43:27 +0000 (16:43 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 23 Jun 2025 23:54:14 +0000 (16:54 -0700)
The dangling warning function that takes a single ref to search for
is no longer used.  Remove it.

Signed-off-by: Phil Hord <phil.hord@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs.c

diff --git a/refs.c b/refs.c
index 18ee7b01584644488ae80283f79234c17aafdddb..dfe64034e7a9f95a51f0f96f21976328fd40f701 100644 (file)
--- a/refs.c
+++ b/refs.c
@@ -438,7 +438,6 @@ static int for_each_filter_refs(const char *refname, const char *referent,
 struct warn_if_dangling_data {
        struct ref_store *refs;
        FILE *fp;
-       const char *refname;
        const struct string_list *refnames;
        const char *msg_fmt;
 };
@@ -455,9 +454,7 @@ static int warn_if_dangling_symref(const char *refname, const char *referent UNU
 
        resolves_to = refs_resolve_ref_unsafe(d->refs, refname, 0, NULL, NULL);
        if (!resolves_to
-           || (d->refname
-               ? strcmp(resolves_to, d->refname)
-               : !string_list_has_string(d->refnames, resolves_to))) {
+           || !string_list_has_string(d->refnames, resolves_to)) {
                return 0;
        }
 
@@ -468,18 +465,6 @@ static int warn_if_dangling_symref(const char *refname, const char *referent UNU
        return 0;
 }
 
-void refs_warn_dangling_symref(struct ref_store *refs, FILE *fp,
-                              const char *msg_fmt, const char *refname)
-{
-       struct warn_if_dangling_data data = {
-               .refs = refs,
-               .fp = fp,
-               .refname = refname,
-               .msg_fmt = msg_fmt,
-       };
-       refs_for_each_rawref(refs, warn_if_dangling_symref, &data);
-}
-
 void refs_warn_dangling_symrefs(struct ref_store *refs, FILE *fp,
                                const char *msg_fmt, const struct string_list *refnames)
 {