]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
PR fortran/34020
authorjakub <jakub@138bc75d-0d04-0410-961f-82ee72b054a4>
Sat, 10 Nov 2007 07:51:55 +0000 (07:51 +0000)
committerjakub <jakub@138bc75d-0d04-0410-961f-82ee72b054a4>
Sat, 10 Nov 2007 07:51:55 +0000 (07:51 +0000)
* gimplify.c (goa_lhs_expr_p): Inside INDIRECT_REF handle unshared
nops.

* testsuite/libgomp.fortran/pr34020.f90: New test.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@130069 138bc75d-0d04-0410-961f-82ee72b054a4

gcc/ChangeLog
gcc/gimplify.c
libgomp/ChangeLog
libgomp/testsuite/libgomp.fortran/pr34020.f90 [new file with mode: 0644]

index ac0e088abf0e793b8a178dfca770a8236ab0c854..2edefc69a9bbec90414a6e3e1a1da8b4bc341eee 100644 (file)
@@ -1,5 +1,9 @@
 2007-11-10  Jakub Jelinek  <jakub@redhat.com>
 
+       PR fortran/34020
+       * gimplify.c (goa_lhs_expr_p): Inside INDIRECT_REF handle unshared
+       nops.
+
        PR middle-end/34018
        * tree-inline.h (copy_body_data): Add regimplify field.
        * tree-inline.c (copy_body_r): Set id->regimplify to true
index 5c11bad3a08510d25740ed1c0fa3bbb685b8a3f4..212a9dc1a60074770cde46c44a4e88d838718d1b 100644 (file)
@@ -5291,8 +5291,22 @@ goa_lhs_expr_p (tree expr, tree addr)
              == TYPE_MAIN_VARIANT (TREE_TYPE (TREE_OPERAND (expr, 0)))))
     expr = TREE_OPERAND (expr, 0);
 
-  if (TREE_CODE (expr) == INDIRECT_REF && TREE_OPERAND (expr, 0) == addr)
-    return true;
+  if (TREE_CODE (expr) == INDIRECT_REF)
+    {
+      expr = TREE_OPERAND (expr, 0);
+      while (expr != addr
+            && (TREE_CODE (expr) == NOP_EXPR
+                || TREE_CODE (expr) == CONVERT_EXPR
+                || TREE_CODE (expr) == NON_LVALUE_EXPR)
+            && TREE_CODE (expr) == TREE_CODE (addr)
+            && TYPE_MAIN_VARIANT (TREE_TYPE (expr))
+               == TYPE_MAIN_VARIANT (TREE_TYPE (addr)))
+       {
+         expr = TREE_OPERAND (expr, 0);
+         addr = TREE_OPERAND (addr, 0);
+       }
+      return expr == addr;
+    }
   if (TREE_CODE (addr) == ADDR_EXPR && expr == TREE_OPERAND (addr, 0))
     return true;
   return false;
index 3a7d2f5d53ef8e7aa3b5cead8426f1e32221d84b..08b417b9a5498d1b37c8c63d2426be2fbe8ff5c0 100644 (file)
@@ -1,3 +1,8 @@
+2007-11-10  Jakub Jelinek  <jakub@redhat.com>
+
+       PR fortran/34020
+       * testsuite/libgomp.fortran/pr34020.f90: New test.
+
 2007-11-06  Jakub Jelinek  <jakub@redhat.com>
 
        PR c++/33894
diff --git a/libgomp/testsuite/libgomp.fortran/pr34020.f90 b/libgomp/testsuite/libgomp.fortran/pr34020.f90
new file mode 100644 (file)
index 0000000..3bb14f5
--- /dev/null
@@ -0,0 +1,19 @@
+! PR fortran/34020
+! { dg-do run }
+
+      subroutine atomic_add(lhs, rhs)
+      real lhs, rhs
+!$omp atomic
+      lhs = rhs + lhs
+      end
+
+      real lhs, rhs
+      integer i
+      lhs = 0
+      rhs = 1
+!$omp parallel do num_threads(8) shared(lhs, rhs)
+      do i = 1, 300000
+        call atomic_add(lhs, rhs)
+      enddo
+      if (lhs .ne. 300000) call abort
+      end