]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
gdbserver: add back lost comments in fast_tracepoint_ctx
authorTankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Wed, 29 Jan 2025 09:50:29 +0000 (10:50 +0100)
committerTankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Wed, 29 Jan 2025 10:17:33 +0000 (11:17 +0100)
Before the removal of the UST/static-tracepoint support, the
`static_tracepoint_ctx` struct contained comments for its fields,
whereas `fast_tracepoint_ctx` did not.  Nevertheless, those comments
also applied to `fast_tracepoint_ctx`.  With the removal of
`static_tracepoint_ctx`, the comments were lost, making
`fast_tracepoint_ctx` data members completely commentless.  Add back
those comments.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
gdbserver/tracepoint.cc

index 1395c70ad39d2ac1b260fc6a0ed507966ac5aa42..559d34dc3e2ee831d311a1dd53077654cab5bb58 100644 (file)
@@ -1184,11 +1184,20 @@ struct fast_tracepoint_ctx
 {
   struct tracepoint_hit_ctx base;
 
+  /* The regcache corresponding to the registers state at the time of
+     the tracepoint hit.  Initialized lazily, from REGS.  */
   struct regcache regcache;
   int regcache_initted;
+
+  /* The buffer space REGCACHE above uses.  We use a separate buffer
+     instead of letting the regcache malloc for both signal safety and
+     performance reasons; this is allocated on the stack instead.  */
   unsigned char *regspace;
 
+  /* The register buffer passed by the client.  */
   unsigned char *regs;
+
+  /* The GDB tracepoint matching the probed marker that was "hit".  */
   struct tracepoint *tpoint;
 };