Remove some useless logs from the TAP tests of pgbench

002_pgbench_no_server was printing some array pointers instead of the
actual contents of those arrays for the expected outputs of stdout and
stderr for a tested command.  This does not add any new information that
can help with debugging as the test names allow to track failure
locations, if any.

This commit simply removes those logs as the rest of the printed
information is redundant with command_checks_all().

Per discussion with Andrew Dunstan and Álvaro Herrera.

Discussion: https://postgr.es/m/YNXNFaG7IgkzZanD@paquier.xyz
Backpatch-through: 11

diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl
index e87c028659d02864be52917c2eda3dc9c65776b2..788154047f43ccd6da5f02ea293f1baaff351343 100644 (file)
--- a/src/bin/pgbench/t/002_pgbench_no_server.pl
+++ b/src/bin/pgbench/t/002_pgbench_no_server.pl
@@ -21,7 +21,6 @@ mkdir $testdir
 sub pgbench
 {
        my ($opts, $stat, $out, $err, $name) = @_;
-       print STDERR "opts=$opts, stat=$stat, out=$out, err=$err, name=$name";
        command_checks_all([ 'pgbench', split(/\s+/, $opts) ],
                $stat, $out, $err, $name);
        return;