]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
interconnect: qcom: remove COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404
authorMao Wenan <maowenan@huawei.com>
Thu, 15 Aug 2019 07:48:48 +0000 (15:48 +0800)
committerGeorgi Djakov <georgi.djakov@linaro.org>
Thu, 15 Aug 2019 08:19:12 +0000 (11:19 +0300)
There is one compilation error when CONFIG_INTERCONNECT_QCOM_QCS404=y and
CONFIG_INTERCONNECT_QCOM_SMD_RPM=y, as well as CONFIG_COMPILE_TEST=y,
but CONFIG_QCOM_SMD_RPM is not set, logs as below:

drivers/interconnect/qcom/smd-rpm.o: In function `qcom_icc_rpm_smd_send':
smd-rpm.c:(.text+0xe4): undefined reference to `qcom_rpm_smd_write'
Makefile:1071: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1

This is because
INTERCONNECT_QCOM_QCS404 depends on QCOM_SMD_RPM || COMPILE_TEST.
Here CONFIG_COMPILE_TEST=y, so CONFIG_INTERCONNECT_QCOM_SMD_RPM
is selected. If CONFIG_QCOM_SMD_RPM is not set, then
qcom_rpm_smd_write() is not defined, and compilation error happen.
Fix this by removing COMPILE_TEST from CONFIG_INTERCONNECT_QCOM_QCS404.

Fixes: 5e4e6c4d3ae0 ("interconnect: qcom: Add QCS404 interconnect provider driver")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
drivers/interconnect/qcom/Kconfig

index 339e8f10d4f393448f8bc4058d759b0595181997..6ab4012a059a57ba06fcee4624f00f2a76c47f38 100644 (file)
@@ -8,7 +8,7 @@ config INTERCONNECT_QCOM
 config INTERCONNECT_QCOM_QCS404
        tristate "Qualcomm QCS404 interconnect driver"
        depends on INTERCONNECT_QCOM
-       depends on QCOM_SMD_RPM || COMPILE_TEST
+       depends on QCOM_SMD_RPM
        select INTERCONNECT_QCOM_SMD_RPM
        help
          This is a driver for the Qualcomm Network-on-Chip on qcs404-based