]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/chrome: cros_ec_proto: remove unnecessary retries
authorDawid Niedzwiecki <dawidn@google.com>
Fri, 6 Dec 2024 09:15:14 +0000 (09:15 +0000)
committerTzung-Bi Shih <tzungbi@kernel.org>
Mon, 30 Dec 2024 01:31:05 +0000 (01:31 +0000)
Remove the retry of the get protocol info command. It is not needed
anymore, because RWSIG continue command is send before start of the
probing. That assures the EC device is ready in RW and there is no
need to try again because FPMCU is not fully booted.

Signed-off-by: Dawid Niedzwiecki <dawidn@google.com>
Link: https://lore.kernel.org/r/20241206091514.2538350-3-dawidn@google.com
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
drivers/platform/chrome/cros_ec_proto.c

index ed3623b54bc3ab96a401e45c68c8907b80fd7003..877b107fee4be055ea4d412449b647f753ba7740 100644 (file)
@@ -366,15 +366,6 @@ static int cros_ec_get_proto_info(struct cros_ec_device *ec_dev, int devidx)
        msg->insize = sizeof(*info);
 
        ret = cros_ec_send_command(ec_dev, msg);
-       /*
-        * Send command once again when timeout occurred.
-        * Fingerprint MCU (FPMCU) is restarted during system boot which
-        * introduces small window in which FPMCU won't respond for any
-        * messages sent by kernel. There is no need to wait before next
-        * attempt because we waited at least EC_MSG_DEADLINE_MS.
-        */
-       if (ret == -ETIMEDOUT)
-               ret = cros_ec_send_command(ec_dev, msg);
 
        if (ret < 0) {
                dev_dbg(ec_dev->dev,