BUG/MAJOR: mux-quic: fix crash on reload during emission

MUX QUIC restricts buffer allocation per connection based on the
underlying congestion window. If a QCS instance cannot allocate a new
buffer, it is put in a buf_wait list. Typically, this will cause stream
upper layer to subscribe for sending.

A BUG_ON() was present on snd_buf and nego_ff callback prologue to
ensure that these functions were not called if QCS is already in
buf_wait list. The objective was to guarantee that there is no wake up
on a stream if it cannot allocate a buffer.

However, this BUG_ON() is not correct, as it can be fired legitimely.
Indeed, stream layer can retry emission even if no wake up occured. This
case can happen on reload. Thus, BUG_ON() will cause an unexpected
crash.

Fix this by removing these BUG_ON(). Instead, snd_buf/nego_ff callbacks
ensure that QCS is not subscribed in buf_wait list. If this is the case,
a nul value will be returned, which is sufficient for the stream layer
to pause emission and subscribe if necessary.

Occurences for this crash have been reported on the mailing list. It is
also the subject of github issue #3080, which should be fixed with this
patch.

This must be backported up to 3.0.

diff --git a/src/mux_quic.c b/src/mux_quic.c
index 8ce0ac71acf279c2f8d9829ea94282c6ae277d39..21f082770aecf27e679773007b807a2b575e3ed4 100644 (file)
--- a/src/mux_quic.c
+++ b/src/mux_quic.c
@@ -4054,9 +4054,6 @@ static size_t qmux_strm_snd_buf(struct stconn *sc, struct buffer *buf,
 
        TRACE_ENTER(QMUX_EV_STRM_SEND, qcs->qcc->conn, qcs);
 
-       /* Stream must not be woken up if already waiting for conn buffer. */
-       BUG_ON(LIST_INLIST(&qcs->el_buf));
-
        /* Sending forbidden if QCS is locally closed (FIN or RESET_STREAM sent). */
        BUG_ON(qcs_is_close_local(qcs) || (qcs->flags & QC_SF_TO_RESET));
 
@@ -4070,6 +4067,11 @@ static size_t qmux_strm_snd_buf(struct stconn *sc, struct buffer *buf,
                goto end;
        }
 
+       if (LIST_INLIST(&qcs->el_buf)) {
+               TRACE_DEVEL("leaving on no buf avail", QMUX_EV_STRM_SEND, qcs->qcc->conn, qcs);
+               goto end;
+       }
+
        if (qfctl_sblocked(&qcs->qcc->tx.fc)) {
                TRACE_DEVEL("leaving on connection flow control",
                            QMUX_EV_STRM_SEND, qcs->qcc->conn, qcs);
@@ -4120,9 +4122,6 @@ static size_t qmux_strm_nego_ff(struct stconn *sc, struct buffer *input,
 
        TRACE_ENTER(QMUX_EV_STRM_SEND, qcs->qcc->conn, qcs);
 
-       /* Stream must not be woken up if already waiting for conn buffer. */
-       BUG_ON(LIST_INLIST(&qcs->el_buf));
-
        /* Sending forbidden if QCS is locally closed (FIN or RESET_STREAM sent). */
        BUG_ON(qcs_is_close_local(qcs) || (qcs->flags & QC_SF_TO_RESET));
 
@@ -4144,6 +4143,12 @@ static size_t qmux_strm_nego_ff(struct stconn *sc, struct buffer *input,
                goto end;
        }
 
+       if (LIST_INLIST(&qcs->el_buf)) {
+               TRACE_DEVEL("leaving on no buf avail", QMUX_EV_STRM_SEND, qcs->qcc->conn, qcs);
+               qcs->sd->iobuf.flags |= IOBUF_FL_FF_BLOCKED;
+               goto end;
+       }
+
        if (qfctl_sblocked(&qcs->qcc->tx.fc)) {
                TRACE_DEVEL("leaving on connection flow control", QMUX_EV_STRM_SEND, qcs->qcc->conn, qcs);
                if (!LIST_INLIST(&qcs->el_fctl)) {