]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
uio: uio_pdrv_genirq: Make use of irq_get_trigger_type()
authorVasileios Amoiridis <vassilisamir@gmail.com>
Thu, 12 Sep 2024 23:59:25 +0000 (01:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Oct 2024 15:16:28 +0000 (17:16 +0200)
Convert the following case:

struct irq_data *irq_data = irq_get_irq_data(irq);

if (irq_data && irqd_get_trigger_type(irq_data) ... ) {
...
}

to the simpler:

if (irq_get_trigger_type(irq) ... ) {
...
}

by using the irq_get_trigger_type() function.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240912235925.54465-3-vassilisamir@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/uio/uio_pdrv_genirq.c

index 796f5be0a086a5cb98607db502a84c03517b432d..2ec7d25e826490999404382e6aa69e4af56f7fe8 100644 (file)
@@ -173,8 +173,6 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
        }
 
        if (uioinfo->irq) {
-               struct irq_data *irq_data = irq_get_irq_data(uioinfo->irq);
-
                /*
                 * If a level interrupt, dont do lazy disable. Otherwise the
                 * irq will fire again since clearing of the actual cause, on
@@ -182,8 +180,7 @@ static int uio_pdrv_genirq_probe(struct platform_device *pdev)
                 * irqd_is_level_type() isn't used since isn't valid until
                 * irq is configured.
                 */
-               if (irq_data &&
-                   irqd_get_trigger_type(irq_data) & IRQ_TYPE_LEVEL_MASK) {
+               if (irq_get_trigger_type(uioinfo->irq) & IRQ_TYPE_LEVEL_MASK) {
                        dev_dbg(&pdev->dev, "disable lazy unmask\n");
                        irq_set_status_flags(uioinfo->irq, IRQ_DISABLE_UNLAZY);
                }