t5520: use test_cmp_rev where possible

In case an invocation of `git rev-list` fails within the command
substitution, the failure will be masked. Remove the command
substitution and use test_cmp_rev() so that failures can be discovered.

This change was done with the following sed expressions:

	s/test "$(git rev-parse.* \([^)]*\))" = "$(git rev-parse \([^)]*\))"/test_cmp_rev \1 \2/
	s/test \([^ ]*\) = "$(git rev-parse.* \([^)]*\))"/test_cmp_rev \1 \2/
	s/test "$(git rev-parse.* \([^)]*\))" != "$(git rev-parse.* \([^)]*\))"/test_cmp_rev ! \1 \2/
	s/test \([^ ]*\) != "$(git rev-parse.* \([^)]*\))"/test_cmp_rev ! \1 \2/

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t5520-pull.sh b/t/t5520-pull.sh
index 18225d84306615cddff6806eb17bfa5d0e0bd740..1af6ea06ee18eda9f8707e65bd20d5a3eeeba81a 100755 (executable)
--- a/t/t5520-pull.sh
+++ b/t/t5520-pull.sh
@@ -230,7 +230,7 @@ test_expect_success 'fast-forwards working tree if branch head is updated' '
        git pull . second:third 2>err &&
        test_i18ngrep "fetch updated the current branch head" err &&
        test "$(cat file)" = modified &&
-       test "$(git rev-parse third)" = "$(git rev-parse second)"
+       test_cmp_rev third second
 '
 
 test_expect_success 'fast-forward fails with conflicting work tree' '
@@ -241,7 +241,7 @@ test_expect_success 'fast-forward fails with conflicting work tree' '
        test_must_fail git pull . second:third 2>err &&
        test_i18ngrep "Cannot fast-forward your working tree" err &&
        test "$(cat file)" = conflict &&
-       test "$(git rev-parse third)" = "$(git rev-parse second)"
+       test_cmp_rev third second
 '
 
 test_expect_success '--rebase' '
@@ -254,7 +254,7 @@ test_expect_success '--rebase' '
        git commit -m "new file" &&
        git tag before-rebase &&
        git pull --rebase . copy &&
-       test "$(git rev-parse HEAD^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^ copy &&
        test new = "$(git show HEAD:file2)"
 '
 
@@ -266,7 +266,7 @@ test_expect_success '--rebase fast forward' '
 
        git checkout to-rebase &&
        git pull --rebase . ff &&
-       test "$(git rev-parse HEAD)" = "$(git rev-parse ff)" &&
+       test_cmp_rev HEAD ff &&
 
        # The above only validates the result.  Did we actually bypass rebase?
        git reflog -1 >reflog.actual &&
@@ -290,7 +290,7 @@ test_expect_success '--rebase --autostash fast forward' '
        git checkout behind &&
        echo dirty >file &&
        git pull --rebase --autostash . to-rebase-ff &&
-       test "$(git rev-parse HEAD)" = "$(git rev-parse to-rebase-ff)"
+       test_cmp_rev HEAD to-rebase-ff
 '
 
 test_expect_success '--rebase with conflicts shows advice' '
@@ -328,7 +328,7 @@ test_expect_success 'failed --rebase shows advice' '
 test_expect_success '--rebase fails with multiple branches' '
        git reset --hard before-rebase &&
        test_must_fail git pull --rebase . copy master 2>err &&
-       test "$(git rev-parse HEAD)" = "$(git rev-parse before-rebase)" &&
+       test_cmp_rev HEAD before-rebase &&
        test_i18ngrep "Cannot rebase onto multiple branches" err &&
        test modified = "$(git show HEAD:file)"
 '
@@ -380,7 +380,7 @@ test_expect_success 'pull.rebase' '
        git reset --hard before-rebase &&
        test_config pull.rebase true &&
        git pull . copy &&
-       test "$(git rev-parse HEAD^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^ copy &&
        test new = "$(git show HEAD:file2)"
 '
 
@@ -398,7 +398,7 @@ test_expect_success 'branch.to-rebase.rebase' '
        git reset --hard before-rebase &&
        test_config branch.to-rebase.rebase true &&
        git pull . copy &&
-       test "$(git rev-parse HEAD^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^ copy &&
        test new = "$(git show HEAD:file2)"
 '
 
@@ -407,14 +407,14 @@ test_expect_success 'branch.to-rebase.rebase should override pull.rebase' '
        test_config pull.rebase true &&
        test_config branch.to-rebase.rebase false &&
        git pull . copy &&
-       test "$(git rev-parse HEAD^)" != "$(git rev-parse copy)" &&
+       test_cmp_rev ! HEAD^ copy &&
        test new = "$(git show HEAD:file2)"
 '
 
 test_expect_success 'pull --rebase warns on --verify-signatures' '
        git reset --hard before-rebase &&
        git pull --rebase --verify-signatures . copy 2>err &&
-       test "$(git rev-parse HEAD^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^ copy &&
        test new = "$(git show HEAD:file2)" &&
        test_i18ngrep "ignoring --verify-signatures for rebase" err
 '
@@ -422,7 +422,7 @@ test_expect_success 'pull --rebase warns on --verify-signatures' '
 test_expect_success 'pull --rebase does not warn on --no-verify-signatures' '
        git reset --hard before-rebase &&
        git pull --rebase --no-verify-signatures . copy 2>err &&
-       test "$(git rev-parse HEAD^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^ copy &&
        test new = "$(git show HEAD:file2)" &&
        test_i18ngrep ! "verify-signatures" err
 '
@@ -443,8 +443,8 @@ test_expect_success 'pull.rebase=false create a new merge commit' '
        git reset --hard before-preserve-rebase &&
        test_config pull.rebase false &&
        git pull . copy &&
-       test "$(git rev-parse HEAD^1)" = "$(git rev-parse before-preserve-rebase)" &&
-       test "$(git rev-parse HEAD^2)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^1 before-preserve-rebase &&
+       test_cmp_rev HEAD^2 copy &&
        test file3 = "$(git show HEAD:file3.t)"
 '
 
@@ -452,7 +452,7 @@ test_expect_success 'pull.rebase=true flattens keep-merge' '
        git reset --hard before-preserve-rebase &&
        test_config pull.rebase true &&
        git pull . copy &&
-       test "$(git rev-parse HEAD^^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^^ copy &&
        test file3 = "$(git show HEAD:file3.t)"
 '
 
@@ -460,7 +460,7 @@ test_expect_success 'pull.rebase=1 is treated as true and flattens keep-merge' '
        git reset --hard before-preserve-rebase &&
        test_config pull.rebase 1 &&
        git pull . copy &&
-       test "$(git rev-parse HEAD^^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^^ copy &&
        test file3 = "$(git show HEAD:file3.t)"
 '
 
@@ -469,8 +469,8 @@ test_expect_success REBASE_P \
        git reset --hard before-preserve-rebase &&
        test_config pull.rebase preserve &&
        git pull . copy &&
-       test "$(git rev-parse HEAD^^)" = "$(git rev-parse copy)" &&
-       test "$(git rev-parse HEAD^2)" = "$(git rev-parse keep-merge)"
+       test_cmp_rev HEAD^^ copy &&
+       test_cmp_rev HEAD^2 keep-merge
 '
 
 test_expect_success 'pull.rebase=interactive' '
@@ -505,8 +505,8 @@ test_expect_success '--rebase=false create a new merge commit' '
        git reset --hard before-preserve-rebase &&
        test_config pull.rebase true &&
        git pull --rebase=false . copy &&
-       test "$(git rev-parse HEAD^1)" = "$(git rev-parse before-preserve-rebase)" &&
-       test "$(git rev-parse HEAD^2)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^1 before-preserve-rebase &&
+       test_cmp_rev HEAD^2 copy &&
        test file3 = "$(git show HEAD:file3.t)"
 '
 
@@ -514,7 +514,7 @@ test_expect_success '--rebase=true rebases and flattens keep-merge' '
        git reset --hard before-preserve-rebase &&
        test_config pull.rebase preserve &&
        git pull --rebase=true . copy &&
-       test "$(git rev-parse HEAD^^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^^ copy &&
        test file3 = "$(git show HEAD:file3.t)"
 '
 
@@ -523,8 +523,8 @@ test_expect_success REBASE_P \
        git reset --hard before-preserve-rebase &&
        test_config pull.rebase true &&
        git pull --rebase=preserve . copy &&
-       test "$(git rev-parse HEAD^^)" = "$(git rev-parse copy)" &&
-       test "$(git rev-parse HEAD^2)" = "$(git rev-parse keep-merge)"
+       test_cmp_rev HEAD^^ copy &&
+       test_cmp_rev HEAD^2 keep-merge
 '
 
 test_expect_success '--rebase=invalid fails' '
@@ -536,7 +536,7 @@ test_expect_success '--rebase overrides pull.rebase=preserve and flattens keep-m
        git reset --hard before-preserve-rebase &&
        test_config pull.rebase preserve &&
        git pull --rebase . copy &&
-       test "$(git rev-parse HEAD^^)" = "$(git rev-parse copy)" &&
+       test_cmp_rev HEAD^^ copy &&
        test file3 = "$(git show HEAD:file3.t)"
 '
 
@@ -597,10 +597,10 @@ test_expect_success 'pull --rebase dies early with dirty working directory' '
        echo dirty >>file &&
        git add file &&
        test_must_fail git pull &&
-       test "$COPY" = "$(git rev-parse --verify me/copy)" &&
+       test_cmp_rev "$COPY" me/copy &&
        git checkout HEAD -- file &&
        git pull &&
-       test "$COPY" != "$(git rev-parse --verify me/copy)"
+       test_cmp_rev ! "$COPY" me/copy
 '
 
 test_expect_success 'pull --rebase works on branch yet to be born' '