]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
KVM: X86: Remove unnecessary GFP_KERNEL_ACCOUNT for temporary variables
authorPeng Hao <flyingpeng@tencent.com>
Mon, 24 Jun 2024 01:20:16 +0000 (09:20 +0800)
committerSean Christopherson <seanjc@google.com>
Fri, 28 Jun 2024 16:52:16 +0000 (09:52 -0700)
Some variables allocated in kvm_arch_vcpu_ioctl are released when
the function exits, so there is no need to set GFP_KERNEL_ACCOUNT.

Signed-off-by: Peng Hao <flyingpeng@tencent.com>
Link: https://lore.kernel.org/r/20240624012016.46133-1-flyingpeng@tencent.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/x86.c

index 33e41103fcde68771a07774f311701758698e4e9..9ef5aaf6ad5c6eb7369bb3499bbe7482a5317b14 100644 (file)
@@ -5884,8 +5884,7 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
                r = -EINVAL;
                if (!lapic_in_kernel(vcpu))
                        goto out;
-               u.lapic = kzalloc(sizeof(struct kvm_lapic_state),
-                               GFP_KERNEL_ACCOUNT);
+               u.lapic = kzalloc(sizeof(struct kvm_lapic_state), GFP_KERNEL);
 
                r = -ENOMEM;
                if (!u.lapic)
@@ -6078,7 +6077,7 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
                if (vcpu->arch.guest_fpu.uabi_size > sizeof(struct kvm_xsave))
                        break;
 
-               u.xsave = kzalloc(sizeof(struct kvm_xsave), GFP_KERNEL_ACCOUNT);
+               u.xsave = kzalloc(sizeof(struct kvm_xsave), GFP_KERNEL);
                r = -ENOMEM;
                if (!u.xsave)
                        break;
@@ -6109,7 +6108,7 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
        case KVM_GET_XSAVE2: {
                int size = vcpu->arch.guest_fpu.uabi_size;
 
-               u.xsave = kzalloc(size, GFP_KERNEL_ACCOUNT);
+               u.xsave = kzalloc(size, GFP_KERNEL);
                r = -ENOMEM;
                if (!u.xsave)
                        break;
@@ -6127,7 +6126,7 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
        }
 
        case KVM_GET_XCRS: {
-               u.xcrs = kzalloc(sizeof(struct kvm_xcrs), GFP_KERNEL_ACCOUNT);
+               u.xcrs = kzalloc(sizeof(struct kvm_xcrs), GFP_KERNEL);
                r = -ENOMEM;
                if (!u.xcrs)
                        break;