BUG/MINOR: acl: fix a double free during exit when using PCRE_JIT

When freeing ACL regex, we don't want to perform the free() in regex_free()
as it's already performed in free_pattern(). The double free only happens
when using PCRE_JIT when freeing everything during exit so it's harmless
but exhibits libc errors during a reload/restart.

Bug reported by Seri.

diff --git a/include/common/regex.h b/include/common/regex.h
index bab1a55cc91a2ae8dfeddf98072fb2cd552c835b..01040195a1244196d54f2e3c4425ec4b3e3f42fd 100644 (file)
--- a/include/common/regex.h
+++ b/include/common/regex.h
@@ -79,7 +79,6 @@ static inline void regex_free(regex *preg) {
 #ifdef USE_PCRE_JIT
        pcre_free_study(preg->extra);
        pcre_free(preg->reg);
-       free(preg);
 #else
        regfree(preg);
 #endif