]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: mptcp: sockopt: use IPPROTO_MPTCP for getaddrinfo
authorGeliang Tang <tanggeliang@kylinos.cn>
Fri, 2 May 2025 12:29:22 +0000 (14:29 +0200)
committerJakub Kicinski <kuba@kernel.org>
Mon, 5 May 2025 23:51:59 +0000 (16:51 -0700)
getaddrinfo MPTCP is recently supported in glibc and IPPROTO_MPTCP for
getaddrinfo is used in mptcp_connect.c. But in mptcp_sockopt.c and
mptcp_inq.c, IPPROTO_TCP are still used for getaddrinfo, So this patch
updates them.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20250502-net-next-mptcp-sft-inc-cover-v1-2-68eec95898fb@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_inq.c
tools/testing/selftests/net/mptcp/mptcp_sockopt.c

index 218aac46732125c005212d0d561ae3bce8f91a74..3cf1e2a612cef911028f46569563d16dd5d32129 100644 (file)
@@ -72,13 +72,21 @@ static const char *getxinfo_strerr(int err)
 }
 
 static void xgetaddrinfo(const char *node, const char *service,
-                        const struct addrinfo *hints,
+                        struct addrinfo *hints,
                         struct addrinfo **res)
 {
+again:
        int err = getaddrinfo(node, service, hints, res);
 
        if (err) {
-               const char *errstr = getxinfo_strerr(err);
+               const char *errstr;
+
+               if (err == EAI_SOCKTYPE) {
+                       hints->ai_protocol = IPPROTO_TCP;
+                       goto again;
+               }
+
+               errstr = getxinfo_strerr(err);
 
                fprintf(stderr, "Fatal: getaddrinfo(%s:%s): %s\n",
                        node ? node : "", service ? service : "", errstr);
@@ -91,7 +99,7 @@ static int sock_listen_mptcp(const char * const listenaddr,
 {
        int sock = -1;
        struct addrinfo hints = {
-               .ai_protocol = IPPROTO_TCP,
+               .ai_protocol = IPPROTO_MPTCP,
                .ai_socktype = SOCK_STREAM,
                .ai_flags = AI_PASSIVE | AI_NUMERICHOST
        };
@@ -136,7 +144,7 @@ static int sock_connect_mptcp(const char * const remoteaddr,
                              const char * const port, int proto)
 {
        struct addrinfo hints = {
-               .ai_protocol = IPPROTO_TCP,
+               .ai_protocol = IPPROTO_MPTCP,
                .ai_socktype = SOCK_STREAM,
        };
        struct addrinfo *a, *addr;
index 926b0be87c9905e763cfb5ba6df974d3518f0b49..9934a68df23708ecb413c4ab26523989e3b9f158 100644 (file)
@@ -159,13 +159,21 @@ static const char *getxinfo_strerr(int err)
 }
 
 static void xgetaddrinfo(const char *node, const char *service,
-                        const struct addrinfo *hints,
+                        struct addrinfo *hints,
                         struct addrinfo **res)
 {
+again:
        int err = getaddrinfo(node, service, hints, res);
 
        if (err) {
-               const char *errstr = getxinfo_strerr(err);
+               const char *errstr;
+
+               if (err == EAI_SOCKTYPE) {
+                       hints->ai_protocol = IPPROTO_TCP;
+                       goto again;
+               }
+
+               errstr = getxinfo_strerr(err);
 
                fprintf(stderr, "Fatal: getaddrinfo(%s:%s): %s\n",
                        node ? node : "", service ? service : "", errstr);
@@ -178,7 +186,7 @@ static int sock_listen_mptcp(const char * const listenaddr,
 {
        int sock = -1;
        struct addrinfo hints = {
-               .ai_protocol = IPPROTO_TCP,
+               .ai_protocol = IPPROTO_MPTCP,
                .ai_socktype = SOCK_STREAM,
                .ai_flags = AI_PASSIVE | AI_NUMERICHOST
        };
@@ -223,7 +231,7 @@ static int sock_connect_mptcp(const char * const remoteaddr,
                              const char * const port, int proto)
 {
        struct addrinfo hints = {
-               .ai_protocol = IPPROTO_TCP,
+               .ai_protocol = IPPROTO_MPTCP,
                .ai_socktype = SOCK_STREAM,
        };
        struct addrinfo *a, *addr;