]> git.ipfire.org Git - people/ms/linux.git/commitdiff
selftests/bpf: Remove SEC("version") from test progs
authorDave Marchevsky <davemarchevsky@fb.com>
Thu, 7 Oct 2021 23:12:34 +0000 (16:12 -0700)
committerAndrii Nakryiko <andrii@kernel.org>
Fri, 8 Oct 2021 05:01:56 +0000 (22:01 -0700)
Since commit 6c4fc209fcf9d ("bpf: remove useless version check for prog
load") these "version" sections, which result in bpf_attr.kern_version
being set, have been unnecessary.

Remove them so that it's obvious to folks using selftests as a guide that
"modern" BPF progs don't need this section.

Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20211007231234.2223081-1-davemarchevsky@fb.com
40 files changed:
tools/testing/selftests/bpf/progs/cgroup_skb_sk_lookup_kern.c
tools/testing/selftests/bpf/progs/connect4_prog.c
tools/testing/selftests/bpf/progs/connect6_prog.c
tools/testing/selftests/bpf/progs/connect_force_port4.c
tools/testing/selftests/bpf/progs/connect_force_port6.c
tools/testing/selftests/bpf/progs/dev_cgroup.c
tools/testing/selftests/bpf/progs/get_cgroup_id_kern.c
tools/testing/selftests/bpf/progs/map_ptr_kern.c
tools/testing/selftests/bpf/progs/netcnt_prog.c
tools/testing/selftests/bpf/progs/sendmsg4_prog.c
tools/testing/selftests/bpf/progs/sendmsg6_prog.c
tools/testing/selftests/bpf/progs/sockmap_parse_prog.c
tools/testing/selftests/bpf/progs/sockmap_tcp_msg_prog.c
tools/testing/selftests/bpf/progs/sockmap_verdict_prog.c
tools/testing/selftests/bpf/progs/sockopt_inherit.c
tools/testing/selftests/bpf/progs/tcp_rtt.c
tools/testing/selftests/bpf/progs/test_btf_haskv.c
tools/testing/selftests/bpf/progs/test_btf_newkv.c
tools/testing/selftests/bpf/progs/test_btf_nokv.c
tools/testing/selftests/bpf/progs/test_l4lb.c
tools/testing/selftests/bpf/progs/test_map_in_map.c
tools/testing/selftests/bpf/progs/test_pinning.c
tools/testing/selftests/bpf/progs/test_pinning_invalid.c
tools/testing/selftests/bpf/progs/test_pkt_access.c
tools/testing/selftests/bpf/progs/test_queue_stack_map.h
tools/testing/selftests/bpf/progs/test_select_reuseport_kern.c
tools/testing/selftests/bpf/progs/test_sk_lookup.c
tools/testing/selftests/bpf/progs/test_skb_cgroup_id_kern.c
tools/testing/selftests/bpf/progs/test_skb_ctx.c
tools/testing/selftests/bpf/progs/test_sockmap_kern.h
tools/testing/selftests/bpf/progs/test_sockmap_listen.c
tools/testing/selftests/bpf/progs/test_stacktrace_build_id.c
tools/testing/selftests/bpf/progs/test_tcp_estats.c
tools/testing/selftests/bpf/progs/test_tcpbpf_kern.c
tools/testing/selftests/bpf/progs/test_tcpnotify_kern.c
tools/testing/selftests/bpf/progs/test_tracepoint.c
tools/testing/selftests/bpf/progs/test_tunnel_kern.c
tools/testing/selftests/bpf/progs/test_xdp.c
tools/testing/selftests/bpf/progs/test_xdp_loop.c
tools/testing/selftests/bpf/progs/test_xdp_redirect.c

index 3f757e30d7a06c3db7269a471e3f85dc3d0fa1d5..88638315c582c2f190c97ab46ebc3975531f6065 100644 (file)
@@ -14,7 +14,6 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 
-int _version SEC("version") = 1;
 char _license[] SEC("license") = "GPL";
 
 __u16 g_serv_port = 0;
index a943d394fd3a04e555e13aa6c108057d8ad477e5..b241932911dbb3bb7ad44ac566a81a4d2716c695 100644 (file)
@@ -31,8 +31,6 @@
 #define IFNAMSIZ 16
 #endif
 
-int _version SEC("version") = 1;
-
 __attribute__ ((noinline))
 int do_bind(struct bpf_sock_addr *ctx)
 {
index 506d0f81a375699ba7aefaeb83e32b862b6e8594..40266d2c737c2e4bd2a92c5de252db2f9959cf6e 100644 (file)
@@ -24,8 +24,6 @@
 
 #define DST_REWRITE_PORT6      6666
 
-int _version SEC("version") = 1;
-
 SEC("cgroup/connect6")
 int connect_v6_prog(struct bpf_sock_addr *ctx)
 {
index a979aaef2a76487e9af71bc5a49057dad9293c96..27a632dd382e00ff051ce097d8d0e994a0df767c 100644 (file)
@@ -13,7 +13,6 @@
 #include <bpf_sockopt_helpers.h>
 
 char _license[] SEC("license") = "GPL";
-int _version SEC("version") = 1;
 
 struct svc_addr {
        __be32 addr;
index afc8f1c5a9d6009de138786427e0a35608597ae5..19cad93e612fc53f0440cc7259928b7d1e9b2491 100644 (file)
@@ -12,7 +12,6 @@
 #include <bpf_sockopt_helpers.h>
 
 char _license[] SEC("license") = "GPL";
-int _version SEC("version") = 1;
 
 struct svc_addr {
        __be32 addr[4];
index 8924e06bdef0634a0bb2763c287c2fb118e5f118..79b54a4fa2446f56c13946370919b5bf2e644ce3 100644 (file)
@@ -57,4 +57,3 @@ int bpf_prog1(struct bpf_cgroup_dev_ctx *ctx)
 }
 
 char _license[] SEC("license") = "GPL";
-__u32 _version SEC("version") = LINUX_VERSION_CODE;
index 6b42db2fe391a435f6428d66e64d024bc6a3d956..68587b1de34e266ed2e83b762424dd173bb3e508 100644 (file)
@@ -37,4 +37,3 @@ int trace(void *ctx)
 }
 
 char _license[] SEC("license") = "GPL";
-__u32 _version SEC("version") = 1; /* ignored by tracepoints, required by libbpf.a */
index d1d304c980f0c4b00427429888008f34ace435cf..b1b711d9b214d54c8c7997807da4df8b12baa823 100644 (file)
@@ -683,5 +683,4 @@ int cg_skb(void *ctx)
        return 1;
 }
 
-__u32 _version SEC("version") = 1;
 char _license[] SEC("license") = "GPL";
index 43649bce4c54067a5c2b00ea2d923401f5af96ba..f718b2c212dc84aa1d42b9098b8feb8d78fd547c 100644 (file)
@@ -68,4 +68,3 @@ int bpf_nextcnt(struct __sk_buff *skb)
 }
 
 char _license[] SEC("license") = "GPL";
-__u32 _version SEC("version") = LINUX_VERSION_CODE;
index ac5abc34cde83529c3dc4c67b3712da91b634680..ea75a44cb7fce5b0d0afb29f8d4e125cf6c3e8fc 100644 (file)
@@ -18,8 +18,6 @@
 #define DST_PORT               4040
 #define DST_REWRITE_PORT4      4444
 
-int _version SEC("version") = 1;
-
 SEC("cgroup/sendmsg4")
 int sendmsg_v4_prog(struct bpf_sock_addr *ctx)
 {
index 24694b1a8d82b0dbab3f00ea0c91c376b646edae..bf9b46b806f6afc59878bf0579316baf219100b7 100644 (file)
@@ -22,8 +22,6 @@
 
 #define DST_REWRITE_PORT6      6666
 
-int _version SEC("version") = 1;
-
 SEC("cgroup/sendmsg6")
 int sendmsg_v6_prog(struct bpf_sock_addr *ctx)
 {
index ca283af80d4e9bbcc97ef9f92d17a4cfcae2bd18..95d5b941bc1f8d46e9fcd5e42c4580ba2aeea337 100644 (file)
@@ -2,8 +2,6 @@
 #include <bpf/bpf_helpers.h>
 #include <bpf/bpf_endian.h>
 
-int _version SEC("version") = 1;
-
 SEC("sk_skb1")
 int bpf_prog1(struct __sk_buff *skb)
 {
index eeaf6e75c9a26e28b093578f396d47d7dbd9c7a9..80632954c5a166768f233a777cef05d51955298b 100644 (file)
@@ -3,8 +3,6 @@
 #include <bpf/bpf_helpers.h>
 #include <bpf/bpf_endian.h>
 
-int _version SEC("version") = 1;
-
 SEC("sk_msg1")
 int bpf_prog1(struct sk_msg_md *msg)
 {
index 73872c535cbb0c850c9563c34d6b2297b497262b..e2468a6d01a59a1f2f333618f5c40c50af59ed82 100644 (file)
@@ -2,8 +2,6 @@
 #include <bpf/bpf_helpers.h>
 #include <bpf/bpf_endian.h>
 
-int _version SEC("version") = 1;
-
 struct {
        __uint(type, BPF_MAP_TYPE_SOCKMAP);
        __uint(max_entries, 20);
index c6d428a8d78574acb69e32cd53621e19105b099d..9fb241b9729197732bd16e96d96bae085e5adebf 100644 (file)
@@ -3,7 +3,6 @@
 #include <bpf/bpf_helpers.h>
 
 char _license[] SEC("license") = "GPL";
-__u32 _version SEC("version") = 1;
 
 #define SOL_CUSTOM                     0xdeadbeef
 #define CUSTOM_INHERIT1                        0
index 0cb3204ddb1829fcd5fa85c9df643c90602d83e9..0988d79f15877fe39c1a7f97266012f5acf7798c 100644 (file)
@@ -3,7 +3,6 @@
 #include <bpf/bpf_helpers.h>
 
 char _license[] SEC("license") = "GPL";
-__u32 _version SEC("version") = 1;
 
 struct tcp_rtt_storage {
        __u32 invoked;
index 31538c9ed1939ca5360d0052086534720de8f67d..160ead6c67b200e57b16506f94ed44eee6a955fc 100644 (file)
@@ -4,8 +4,6 @@
 #include <bpf/bpf_helpers.h>
 #include "bpf_legacy.h"
 
-int _version SEC("version") = 1;
-
 struct ipv_counts {
        unsigned int v4;
        unsigned int v6;
index 6c5560162746b8a336f2086855889ebba388ac85..1884a5bd10f568a6cfd999c9a93f2529f13a539d 100644 (file)
@@ -4,8 +4,6 @@
 #include <bpf/bpf_helpers.h>
 #include "bpf_legacy.h"
 
-int _version SEC("version") = 1;
-
 struct ipv_counts {
        unsigned int v4;
        unsigned int v6;
index 506da7fd2da2376d93605a9ceb49559fb5b9ccc3..15e0f9945fe469fae6bde149ea445234b018f0ec 100644 (file)
@@ -3,8 +3,6 @@
 #include <linux/bpf.h>
 #include <bpf/bpf_helpers.h>
 
-int _version SEC("version") = 1;
-
 struct ipv_counts {
        unsigned int v4;
        unsigned int v6;
index 33493911d87a4fdf007f40131ef84770aa724e2b..04fee08863cb1513783ef2cd02a19f696600d1c9 100644 (file)
@@ -21,8 +21,6 @@
 #include "test_iptunnel_common.h"
 #include <bpf/bpf_endian.h>
 
-int _version SEC("version") = 1;
-
 static inline __u32 rol32(__u32 word, unsigned int shift)
 {
        return (word << shift) | (word >> ((-shift) & 31));
index a6d91932dcd51aa50eb58acf73d933be86b729d3..f416032ba858b48e4fba79dd1d629bd268eb13f5 100644 (file)
@@ -47,5 +47,4 @@ int xdp_mimtest0(struct xdp_md *ctx)
        return XDP_PASS;
 }
 
-int _version SEC("version") = 1;
 char _license[] SEC("license") = "GPL";
index 4ef2630292b261de9ea78e41583bbe7fe337af28..0facea6cbbaed97dc2d0b2d6c4288aa90428768b 100644 (file)
@@ -3,8 +3,6 @@
 #include <linux/bpf.h>
 #include <bpf/bpf_helpers.h>
 
-int _version SEC("version") = 1;
-
 struct {
        __uint(type, BPF_MAP_TYPE_ARRAY);
        __uint(max_entries, 1);
index 5412e0c732c7601c98600e4cea95e2336fcbf37e..2a56db1094b875f36e2b054bf464ec9f66a74afa 100644 (file)
@@ -3,8 +3,6 @@
 #include <linux/bpf.h>
 #include <bpf/bpf_helpers.h>
 
-int _version SEC("version") = 1;
-
 struct {
        __uint(type, BPF_MAP_TYPE_ARRAY);
        __uint(max_entries, 1);
index 3cfd88141ddc1823ef8f6013fbd2b18bfb50ff07..0558544e1ff0fb0749ba1668a99c06b4a1708d8e 100644 (file)
@@ -15,7 +15,6 @@
 #include <bpf/bpf_endian.h>
 
 #define barrier() __asm__ __volatile__("": : :"memory")
-int _version SEC("version") = 1;
 
 /* llvm will optimize both subprograms into exactly the same BPF assembly
  *
index 4dd9806ad73b5bae9c9153c43daa280a1b0f821a..0fcd3ff0e38a2a0c9365a8b8f66329ac2debd9c9 100644 (file)
@@ -8,8 +8,6 @@
 #include <linux/pkt_cls.h>
 #include <bpf/bpf_helpers.h>
 
-int _version SEC("version") = 1;
-
 struct {
        __uint(type, MAP_TYPE);
        __uint(max_entries, 32);
index 0f9bc258225eced3b2fdc88334cec8bca482a735..7d56ed47cd4d86e80ba8f497838ada6d24a8d8a6 100644 (file)
@@ -15,8 +15,6 @@
 #include <bpf/bpf_helpers.h>
 #include "test_select_reuseport_common.h"
 
-int _version SEC("version") = 1;
-
 #ifndef offsetof
 #define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)
 #endif
index 48534d81039181d7bae06271336a4714f78b20bf..19d2465d94425b6fbaae808480a7525ca0a8bcbc 100644 (file)
@@ -644,4 +644,3 @@ int multi_prog_redir2(struct bpf_sk_lookup *ctx)
 }
 
 char _license[] SEC("license") = "Dual BSD/GPL";
-__u32 _version SEC("version") = 1;
index 552f2090665c504b9c7274115982a98c59f9f819..c304cd5b8cad78d8a86c21287b3bf949e082304e 100644 (file)
@@ -42,6 +42,4 @@ int log_cgroup_id(struct __sk_buff *skb)
        return TC_ACT_OK;
 }
 
-int _version SEC("version") = 1;
-
 char _license[] SEC("license") = "GPL";
index ba4dab09d19c40eb2b6f08b4f39f17b7c3f1739a..1d61b36e6067e3af35725c12abdf75c7339cb36a 100644 (file)
@@ -3,7 +3,6 @@
 #include <linux/bpf.h>
 #include <bpf/bpf_helpers.h>
 
-int _version SEC("version") = 1;
 char _license[] SEC("license") = "GPL";
 
 SEC("skb_ctx")
index 1858435de7aaf91a3f2ef12e1c8a74e9ee934c4e..2966564b8497aa4cd03049a209e2044e580a652c 100644 (file)
@@ -361,5 +361,4 @@ int bpf_prog10(struct sk_msg_md *msg)
        return SK_DROP;
 }
 
-int _version SEC("version") = 1;
 char _license[] SEC("license") = "GPL";
index 00f1456aaeda2514278d6fe6ca494bbae8e380ec..325c9f193432aaa0b2efeb62088389c91b52d2c2 100644 (file)
@@ -116,5 +116,4 @@ int prog_reuseport(struct sk_reuseport_md *reuse)
        return verdict;
 }
 
-int _version SEC("version") = 1;
 char _license[] SEC("license") = "GPL";
index 7449fdb1763b14bb89e26acb168c128c1745abd2..36a707e7c7a7abb965053e067b4c4e2a519356e5 100644 (file)
@@ -73,4 +73,3 @@ int oncpu(struct random_urandom_args *args)
 }
 
 char _license[] SEC("license") = "GPL";
-__u32 _version SEC("version") = 1; /* ignored by tracepoints, required by libbpf.a */
index adc83a54c35270deeae584363f06895a78eebff4..2c5c602c60114b15b03e83bff11e995366728110 100644 (file)
@@ -255,4 +255,3 @@ int _dummy_tracepoint(struct dummy_tracepoint_args *arg)
 }
 
 char _license[] SEC("license") = "GPL";
-__u32 _version SEC("version") = 1; /* ignored by tracepoints, required by libbpf.a */
index 94f50f7e94d64ee5d5c21e83fbd1c0fb04b30d8f..3ded052807576ea4dd0dea1f180179a0d2b5eee3 100644 (file)
@@ -16,7 +16,6 @@
 #include "test_tcpbpf.h"
 
 struct tcpbpf_globals global = {};
-int _version SEC("version") = 1;
 
 /**
  * SOL_TCP is defined in <netinet/tcp.h> while
index 24e9344994ef9f2dcb33086f1ad7492c59b1bb94..540181c115a85afc327f0c341e9ba6e087b99c68 100644 (file)
@@ -28,8 +28,6 @@ struct {
        __type(value, __u32);
 } perf_event_map SEC(".maps");
 
-int _version SEC("version") = 1;
-
 SEC("sockops")
 int bpf_testcb(struct bpf_sock_ops *skops)
 {
index 4b825ee122cf8cc5d674e841214f42132e53368d..ce6974016f53fa525fe789e21e76df9aaafef1d8 100644 (file)
@@ -23,4 +23,3 @@ int oncpu(struct sched_switch_args *ctx)
 }
 
 char _license[] SEC("license") = "GPL";
-__u32 _version SEC("version") = 1; /* ignored by tracepoints, required by libbpf.a */
index e7b6731174364147776397f46f45adee99fac982..ef0dde83b85acdbe11a77fd5ee747d7d91919197 100644 (file)
@@ -26,8 +26,6 @@
                bpf_trace_printk(fmt, sizeof(fmt), __LINE__, ret); \
        } while (0)
 
-int _version SEC("version") = 1;
-
 struct geneve_opt {
        __be16  opt_class;
        __u8    type;
index e6aa2fc6ce6bd4594d95540dca96672e53368753..d7a9a74b7245390504e1e6e1c6c5f0fac9f51883 100644 (file)
@@ -20,8 +20,6 @@
 #include <bpf/bpf_endian.h>
 #include "test_iptunnel_common.h"
 
-int _version SEC("version") = 1;
-
 struct {
        __uint(type, BPF_MAP_TYPE_PERCPU_ARRAY);
        __uint(max_entries, 256);
index 27eb52dda92c21f23605c0f23a54f6b3f38f99c9..c98fb44156f04d3d2a0f96ed2b3725060fc47a9e 100644 (file)
@@ -16,8 +16,6 @@
 #include <bpf/bpf_endian.h>
 #include "test_iptunnel_common.h"
 
-int _version SEC("version") = 1;
-
 struct {
        __uint(type, BPF_MAP_TYPE_PERCPU_ARRAY);
        __uint(max_entries, 256);
index a5337cd9400bebae5dcb1915e4f29e433bac2d86..b778cad454852ed3a1808aca665dd9f9cc2b6c7b 100644 (file)
@@ -12,8 +12,6 @@
 #include <linux/bpf.h>
 #include <bpf/bpf_helpers.h>
 
-int _version SEC("version") = 1;
-
 SEC("redirect_to_111")
 int xdp_redirect_to_111(struct xdp_md *xdp)
 {