]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
regulator: qcom_spmi: Use of_property_read_bool()
authorRob Herring (Arm) <robh@kernel.org>
Wed, 28 Aug 2024 13:00:55 +0000 (08:00 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 28 Aug 2024 20:52:45 +0000 (21:52 +0100)
Use of_property_read_bool() to read boolean properties rather than
of_find_property(). This is part of a larger effort to remove callers
of of_find_property() and similar functions. of_find_property() leaks
the DT property pointer which is a problem for dynamically allocated
nodes which may be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20240828130056.3481050-2-robh@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/qcom_spmi-regulator.c

index 68603649db48ee03fe36eee3fc8cf4fee3274f57..89657e8eea82e73985219ac77a017b8dd7d8ee7f 100644 (file)
@@ -2577,15 +2577,13 @@ static int qcom_spmi_regulator_probe(struct platform_device *pdev)
 
                if (saw_regmap) {
                        reg_node = of_get_child_by_name(node, reg->name);
-                       reg_prop = of_find_property(reg_node, "qcom,saw-leader",
-                                                   &lenp);
-                       of_node_put(reg_node);
-                       if (reg_prop) {
+                       if (of_property_read_bool(reg_node, "qcom,saw-leader")) {
                                spmi_saw_ops = *(vreg->desc.ops);
                                spmi_saw_ops.set_voltage_sel =
                                        spmi_regulator_saw_set_voltage;
                                vreg->desc.ops = &spmi_saw_ops;
                        }
+                       of_node_put(reg_node);
                }
 
                if (vreg->set_points && vreg->set_points->count == 1) {