]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nvme: fix endianness of command word prints in nvme_log_err_passthru()
authorJohn Garry <john.g.garry@oracle.com>
Mon, 30 Jun 2025 16:21:53 +0000 (16:21 +0000)
committerChristoph Hellwig <hch@lst.de>
Mon, 14 Jul 2025 13:51:06 +0000 (15:51 +0200)
The command word members of struct nvme_common_command are __le32 type,
so use helper le32_to_cpu() to read them properly.

Fixes: 9f079dda1433 ("nvme: allow passthru cmd error logging")
Signed-off-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Alan Adamson <alan.adamson@oracle.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c

index 5eb45d26c553bd6e40d55f388f8c1b3c9494894c..1d2240494f3de18b1c6216f8ce971026b305d31e 100644 (file)
@@ -381,12 +381,12 @@ static void nvme_log_err_passthru(struct request *req)
                nr->status & NVME_SC_MASK,      /* Status Code */
                nr->status & NVME_STATUS_MORE ? "MORE " : "",
                nr->status & NVME_STATUS_DNR  ? "DNR "  : "",
-               nr->cmd->common.cdw10,
-               nr->cmd->common.cdw11,
-               nr->cmd->common.cdw12,
-               nr->cmd->common.cdw13,
-               nr->cmd->common.cdw14,
-               nr->cmd->common.cdw15);
+               le32_to_cpu(nr->cmd->common.cdw10),
+               le32_to_cpu(nr->cmd->common.cdw11),
+               le32_to_cpu(nr->cmd->common.cdw12),
+               le32_to_cpu(nr->cmd->common.cdw13),
+               le32_to_cpu(nr->cmd->common.cdw14),
+               le32_to_cpu(nr->cmd->common.cdw15));
 }
 
 enum nvme_disposition {