]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
Fix a logic problem in handling of --up scripts in t_client.sh
authorSamuli Seppänen <samuli@openvpn.net>
Wed, 9 Nov 2016 12:42:05 +0000 (14:42 +0200)
committerGert Doering <gert@greenie.muc.de>
Wed, 9 Nov 2016 12:53:44 +0000 (13:53 +0100)
Previously the $up variable was never reset after being set. This mean that
"--up update_t_client_ips.sh" was appended to all subsequent openvpn
command-lines, even if cached IPs existed.

Signed-off-by: Samuli Seppänen <samuli@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1478695325-18038-1-git-send-email-samuli@openvpn.net>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg12979.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
tests/t_client.sh.in

index 076f6bd86e7175118c9a9ac7028e9c0bc2fbdbac..b92cb65deabb95c228b9036628447975a5cac49b 100755 (executable)
@@ -276,6 +276,8 @@ do
     # script to generate them dynamically.
     if [ -z "$expect_ifconfig4" ] || [ -z "$expect_ifconfig6" ]; then
         up="--setenv TESTNUM $SUF --setenv TOP_BUILDDIR ${top_builddir} --script-security 2 --up ${srcdir}/update_t_client_ips.sh"
+    else
+        up=""
     fi
 
     echo -e "\n### test run $SUF: '$test_run_title' ###\n"