Keep WAL segments by the flushed value of the slot's restart LSN

The patch fixes the issue with the unexpected removal of old WAL segments
after checkpoint, followed by an immediate restart.  The issue occurs when
a slot is advanced after the start of the checkpoint and before old WAL
segments are removed at the end of the checkpoint.

The idea of the patch is to get the minimal restart_lsn at the beginning
of checkpoint (or restart point) creation and use this value when calculating
the oldest LSN for WAL segments removal at the end of checkpoint.  This idea
was proposed by Tomas Vondra in the discussion.  Unlike 291221c46575, this
fix doesn't affect ABI and is intended for back branches.

Discussion: https://postgr.es/m/flat/1d12d2-67235980-35-19a406a0%4063439497
Author: Vitaly Davydov <v.davydov@postgrespro.ru>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Reviewed-by: Alexander Korotkov <aekorotkov@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 13

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 818284759d9a954ee5d71dafb88c9633d143c11b..dc11af7cbcd5395aeed6b66a1f143309c67d9630 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -646,7 +646,8 @@ static XLogRecPtr CreateOverwriteContrecordRecord(XLogRecPtr aborted_lsn,
                                                                                                  XLogRecPtr missingContrecPtr,
                                                                                                  TimeLineID newTLI);
 static void CheckPointGuts(XLogRecPtr checkPointRedo, int flags);
-static void KeepLogSeg(XLogRecPtr recptr, XLogSegNo *logSegNo);
+static void KeepLogSeg(XLogRecPtr recptr, XLogRecPtr slotsMinLSN,
+                                          XLogSegNo *logSegNo);
 static XLogRecPtr XLogGetReplicationSlotMinimumLSN(void);
 
 static void AdvanceXLInsertBuffer(XLogRecPtr upto, TimeLineID tli,
@@ -6333,6 +6334,7 @@ CreateCheckPoint(int flags)
        VirtualTransactionId *vxids;
        int                     nvxids;
        int                     oldXLogAllowed = 0;
+       XLogRecPtr      slotsMinReqLSN;
 
        /*
         * An end-of-recovery checkpoint is really a shutdown checkpoint, just
@@ -6534,6 +6536,15 @@ CreateCheckPoint(int flags)
         */
        END_CRIT_SECTION();
 
+       /*
+        * Get the current minimum LSN to be used later in the WAL segment
+        * cleanup.  We may clean up only WAL segments, which are not needed
+        * according to synchronized LSNs of replication slots.  The slot's LSN
+        * might be advanced concurrently, so we call this before
+        * CheckPointReplicationSlots() synchronizes replication slots.
+        */
+       slotsMinReqLSN = XLogGetReplicationSlotMinimumLSN();
+
        /*
         * In some cases there are groups of actions that must all occur on one
         * side or the other of a checkpoint record. Before flushing the
@@ -6699,15 +6710,23 @@ CreateCheckPoint(int flags)
         * prevent the disk holding the xlog from growing full.
         */
        XLByteToSeg(RedoRecPtr, _logSegNo, wal_segment_size);
-       KeepLogSeg(recptr, &_logSegNo);
+       KeepLogSeg(recptr, slotsMinReqLSN, &_logSegNo);
        if (InvalidateObsoleteReplicationSlots(_logSegNo))
        {
+               /*
+                * Recalculate the current minimum LSN to be used in the WAL segment
+                * cleanup.  Then, we must synchronize the replication slots again in
+                * order to make this LSN safe to use.
+                */
+               slotsMinReqLSN = XLogGetReplicationSlotMinimumLSN();
+               CheckPointReplicationSlots();
+
                /*
                 * Some slots have been invalidated; recalculate the old-segment
                 * horizon, starting again from RedoRecPtr.
                 */
                XLByteToSeg(RedoRecPtr, _logSegNo, wal_segment_size);
-               KeepLogSeg(recptr, &_logSegNo);
+               KeepLogSeg(recptr, slotsMinReqLSN, &_logSegNo);
        }
        _logSegNo--;
        RemoveOldXlogFiles(_logSegNo, RedoRecPtr, recptr,
@@ -6979,6 +6998,7 @@ CreateRestartPoint(int flags)
        XLogRecPtr      endptr;
        XLogSegNo       _logSegNo;
        TimestampTz xtime;
+       XLogRecPtr      slotsMinReqLSN;
 
        /* Concurrent checkpoint/restartpoint cannot happen */
        Assert(!IsUnderPostmaster || MyBackendType == B_CHECKPOINTER);
@@ -7061,6 +7081,15 @@ CreateRestartPoint(int flags)
        MemSet(&CheckpointStats, 0, sizeof(CheckpointStats));
        CheckpointStats.ckpt_start_t = GetCurrentTimestamp();
 
+       /*
+        * Get the current minimum LSN to be used later in the WAL segment
+        * cleanup.  We may clean up only WAL segments, which are not needed
+        * according to synchronized LSNs of replication slots.  The slot's LSN
+        * might be advanced concurrently, so we call this before
+        * CheckPointReplicationSlots() synchronizes replication slots.
+        */
+       slotsMinReqLSN = XLogGetReplicationSlotMinimumLSN();
+
        if (log_checkpoints)
                LogCheckpointStart(flags, true);
 
@@ -7143,15 +7172,23 @@ CreateRestartPoint(int flags)
        receivePtr = GetWalRcvFlushRecPtr(NULL, NULL);
        replayPtr = GetXLogReplayRecPtr(&replayTLI);
        endptr = (receivePtr < replayPtr) ? replayPtr : receivePtr;
-       KeepLogSeg(endptr, &_logSegNo);
+       KeepLogSeg(endptr, slotsMinReqLSN, &_logSegNo);
        if (InvalidateObsoleteReplicationSlots(_logSegNo))
        {
+               /*
+                * Recalculate the current minimum LSN to be used in the WAL segment
+                * cleanup.  Then, we must synchronize the replication slots again in
+                * order to make this LSN safe to use.
+                */
+               slotsMinReqLSN = XLogGetReplicationSlotMinimumLSN();
+               CheckPointReplicationSlots();
+
                /*
                 * Some slots have been invalidated; recalculate the old-segment
                 * horizon, starting again from RedoRecPtr.
                 */
                XLByteToSeg(RedoRecPtr, _logSegNo, wal_segment_size);
-               KeepLogSeg(endptr, &_logSegNo);
+               KeepLogSeg(endptr, slotsMinReqLSN, &_logSegNo);
        }
        _logSegNo--;
 
@@ -7245,6 +7282,7 @@ GetWALAvailability(XLogRecPtr targetLSN)
        XLogSegNo       oldestSegMaxWalSize;    /* oldest segid kept by max_wal_size */
        XLogSegNo       oldestSlotSeg;  /* oldest segid kept by slot */
        uint64          keepSegs;
+       XLogRecPtr      slotsMinReqLSN;
 
        /*
         * slot does not reserve WAL. Either deactivated, or has never been active
@@ -7258,8 +7296,9 @@ GetWALAvailability(XLogRecPtr targetLSN)
         * oldestSlotSeg to the current segment.
         */
        currpos = GetXLogWriteRecPtr();
+       slotsMinReqLSN = XLogGetReplicationSlotMinimumLSN();
        XLByteToSeg(currpos, oldestSlotSeg, wal_segment_size);
-       KeepLogSeg(currpos, &oldestSlotSeg);
+       KeepLogSeg(currpos, slotsMinReqLSN, &oldestSlotSeg);
 
        /*
         * Find the oldest extant segment file. We get 1 until checkpoint removes
@@ -7320,7 +7359,7 @@ GetWALAvailability(XLogRecPtr targetLSN)
  * invalidation is optionally done here, instead.
  */
 static void
-KeepLogSeg(XLogRecPtr recptr, XLogSegNo *logSegNo)
+KeepLogSeg(XLogRecPtr recptr, XLogRecPtr slotsMinReqLSN, XLogSegNo *logSegNo)
 {
        XLogSegNo       currSegNo;
        XLogSegNo       segno;
@@ -7333,7 +7372,7 @@ KeepLogSeg(XLogRecPtr recptr, XLogSegNo *logSegNo)
         * Calculate how many segments are kept by slots first, adjusting for
         * max_slot_wal_keep_size.
         */
-       keep = XLogGetReplicationSlotMinimumLSN();
+       keep = slotsMinReqLSN;
        if (keep != InvalidXLogRecPtr && keep < recptr)
        {
                XLByteToSeg(keep, segno, wal_segment_size);

diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c
index 74e22fff78df3291f33cb69db7759ff2b90f603c..e9105edaef572e63cd5b80bd85b47c3f3b10520f 100644 (file)
--- a/src/backend/replication/logical/logical.c
+++ b/src/backend/replication/logical/logical.c
@@ -1803,7 +1803,15 @@ LogicalConfirmReceivedLocation(XLogRecPtr lsn)
 
                SpinLockRelease(&MyReplicationSlot->mutex);
 
-               /* first write new xmin to disk, so we know what's up after a crash */
+               /*
+                * First, write new xmin and restart_lsn to disk so we know what's up
+                * after a crash.  Even when we do this, the checkpointer can see the
+                * updated restart_lsn value in the shared memory; then, a crash can
+                * happen before we manage to write that value to the disk.  Thus,
+                * checkpointer still needs to make special efforts to keep WAL
+                * segments required by the restart_lsn written to the disk.  See
+                * CreateCheckPoint() and CreateRestartPoint() for details.
+                */
                if (updated_xmin || updated_restart)
                {
                        ReplicationSlotMarkDirty();

diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
index 4bd4bb7aa0d25d25a000e8415fde59119a8a420b..a72424a861e343ebbdbe37bf89127511dda86242 100644 (file)
--- a/src/backend/replication/walsender.c
+++ b/src/backend/replication/walsender.c
@@ -2065,6 +2065,10 @@ PhysicalConfirmReceivedLocation(XLogRecPtr lsn)
         * be energy wasted - the worst lost information can do here is give us
         * wrong information in a statistics view - we'll just potentially be more
         * conservative in removing files.
+        *
+        * Checkpointer makes special efforts to keep the WAL segments required by
+        * the restart_lsn written to the disk. See CreateCheckPoint() and
+        * CreateRestartPoint() for details.
         */
 }