]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
s390/qeth: remove RX seqno in skb->cb
authorJulian Wiedmann <jwi@linux.ibm.com>
Thu, 25 Apr 2019 16:25:55 +0000 (18:25 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Apr 2019 15:14:06 +0000 (11:14 -0400)
It's unclear what exact purpose this seqno may have served in the past.
But it's certainly no longer used anymore, as the following
napi_gro_receive() will straight away clear this part of the cb again.

Suggested-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core.h
drivers/s390/net/qeth_l2_main.c

index 86cae5e8e2c20a055f45db3a78495a08d4017361..962e958c24f9cc131752e3dd1cd379d88d99f113 100644 (file)
@@ -652,7 +652,6 @@ struct qeth_seqno {
        __u32 pdu_hdr;
        __u32 pdu_hdr_ack;
        __u16 ipa;
-       __u32 pkt_seqno;
 };
 
 struct qeth_reply {
index e26a6dff286fd134401089f91f7214baa58730de..07bfb110906ddbf61cbda34baf4d2c83c8259410 100644 (file)
@@ -332,8 +332,6 @@ static int qeth_l2_process_inbound_buffer(struct qeth_card *card,
                case QETH_HEADER_TYPE_LAYER2:
                        skb->protocol = eth_type_trans(skb, skb->dev);
                        qeth_rx_csum(card, skb, hdr->hdr.l2.flags[1]);
-                       if (skb->protocol == htons(ETH_P_802_2))
-                               *((__u32 *)skb->cb) = ++card->seqno.pkt_seqno;
                        len = skb->len;
                        napi_gro_receive(&card->napi, skb);
                        break;