CI lint:clang-scan-build - more error reductions

diff --git a/lib/cache/entry_rr.c b/lib/cache/entry_rr.c
index ec6e4b5ed462d635394fb1f40f62c036aa4d272a..94dd0e83e702c1465f9b8e0f51cc390c09d07ec5 100644 (file)
--- a/lib/cache/entry_rr.c
+++ b/lib/cache/entry_rr.c
@@ -41,7 +41,7 @@ int rdataset_dematerialize(const knot_rdataset_t *rds, uint8_t * restrict data)
                data += size;
        }
        //VERBOSE_MSG(NULL, "dematerialized to %d B\n", (int)(data - data0));
-       //return data - data0;
+       (void)data;
        return kr_ok();
 }
 

diff --git a/tests/clang_scan_build.sh b/tests/clang_scan_build.sh
index 12831310e6ce4141c561653321e6a876f7ecd0ca..8d7398fff3b93fcd5ad9e556d36342931e5278f9 100755 (executable)
--- a/tests/clang_scan_build.sh
+++ b/tests/clang_scan_build.sh
@@ -9,15 +9,15 @@ set -o errexit -o nounset
 # https://bugs.llvm.org/show_bug.cgi?id=3888
 
 # These are disabled for other reasons:
+# alpha.clone.CloneChecker # way too many false positives
+# alpha.core.CastToStruct # we use this pattern too much, hard to avoid in many cases
 # alpha.deadcode.UnreachableCode # false positives/flags sanity checks depending on implementation details
 # alpha.security.MallocOverflow # not smart enough to infer max values from data types
-# alpha.clone.CloneChecker # way too many false positives
 
 ${SCAN_BUILD:-scan-build} \
 -disable-checker  unix.Malloc \
 -enable-checker   alpha.core.BoolAssignment \
 -enable-checker   alpha.core.CallAndMessageUnInitRefArg \
--enable-checker   alpha.core.CastToStruct \
 -enable-checker   alpha.core.CastSize \
 -enable-checker   alpha.core.Conversion \
 -enable-checker   alpha.core.DynamicTypeChecker \