Author: Stefan Fritsch <sf@sfritsch.de>

Bug #3058 fix: errorSend and ICY leak MemBuf object.

HttpReply::pack() returns a MemBuf pointer that must be deleted. Fixed leaking
errorSend() function in errorpage.cc and ICY parsing hack in
HttpStateData::processReplyHeader().

diff --git a/src/errorpage.cc b/src/errorpage.cc
index 7e80a965ec205661eb0bd659968fbb9fb1083e6b..bcc3e2e966167eb213ab7e395c6eb53ae6a80eb6 100644 (file)
--- a/src/errorpage.cc
+++ b/src/errorpage.cc
@@ -457,7 +457,9 @@ errorSend(int fd, ErrorState * err)
 
     rep = err->BuildHttpReply();
 
-    comm_write_mbuf(fd, rep->pack(), errorSendComplete, err);
+    MemBuf *mb = rep->pack();
+    comm_write_mbuf(fd, mb, errorSendComplete, err);
+    delete mb;
 
     delete rep;
 }

diff --git a/src/http.cc b/src/http.cc
index 597ad6c4f61cfc9cb0e91d240586632393a48277..6f613729a9163108ea21af471223020a4f350747 100644 (file)
--- a/src/http.cc
+++ b/src/http.cc
@@ -680,6 +680,7 @@ HttpStateData::processReplyHeader()
         tmprep->header.putExt("X-Transformed-From", "HTTP/0.9");
         mb = tmprep->pack();
         newrep->parse(mb, eof, &error);
+        delete mb;
         delete tmprep;
     } else {
         if (!parsed && error > 0) { // unrecoverable parsing error