]> git.ipfire.org Git - thirdparty/git.git/commitdiff
pack-bitmap: clarify comment in filter_bitmap_exclude_type()
authorTaylor Blau <me@ttaylorr.com>
Tue, 20 Jul 2021 20:16:22 +0000 (16:16 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 20 Jul 2021 22:04:07 +0000 (15:04 -0700)
The code that eventually became filter_bitmap_exclude_type() was
originally introduced in 4f3bd5606a (pack-bitmap: implement BLOB_NONE
filtering, 2020-02-14) to accelerate BLOB_NONE filters with bitmaps.

In 856e12c18a (pack-bitmap.c: make object filtering functions generic,
2020-05-04), it became filter_bitmap_exclude_type(). But not all of the
comments were updated to be agnostic to the provided type.

Remove the remaining comments which should have been updated in
856e12c18a to reflect the type-agnostic nature of the function.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
pack-bitmap.c

index 4077e731e800c52548243452e9a5cf715a8f43b0..d5860c143e880db4405c36284d14a935c8a6a654 100644 (file)
@@ -762,8 +762,9 @@ static void filter_bitmap_exclude_type(struct bitmap_index *bitmap_git,
        tips = find_tip_objects(bitmap_git, tip_objects, type);
 
        /*
-        * We can use the blob type-bitmap to work in whole words
-        * for the objects that are actually in the bitmapped packfile.
+        * We can use the type-level bitmap for 'type' to work in whole
+        * words for the objects that are actually in the bitmapped
+        * packfile.
         */
        for (i = 0, init_type_iterator(&it, bitmap_git, type);
             i < to_filter->word_alloc && ewah_iterator_next(&mask, &it);
@@ -774,9 +775,9 @@ static void filter_bitmap_exclude_type(struct bitmap_index *bitmap_git,
        }
 
        /*
-        * Clear any blobs that weren't in the packfile (and so would not have
-        * been caught by the loop above. We'll have to check them
-        * individually.
+        * Clear any objects that weren't in the packfile (and so would
+        * not have been caught by the loop above. We'll have to check
+        * them individually.
         */
        for (i = 0; i < eindex->count; i++) {
                uint32_t pos = i + bitmap_git->pack->num_objects;