]> git.ipfire.org Git - thirdparty/git.git/commitdiff
remote-mediawiki tests: use a more idiomatic dispatch table
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Mon, 21 Sep 2020 10:39:51 +0000 (12:39 +0200)
committerJunio C Hamano <gitster@pobox.com>
Mon, 21 Sep 2020 19:37:38 +0000 (12:37 -0700)
Change the dispatch table code in test-gitmw.pl to use a hash where
subroutine references are the values. This is more obvious than a hash
where the values are strings we'll use to go searching around in the
symbol table for the function.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/mw-to-git/t/test-gitmw.pl

index 0ff76259faa6854345203bd3fbcdb738b789bff1..afc4650b1aa54516ee317a6a1d7985ab4f01f09e 100755 (executable)
@@ -214,12 +214,12 @@ my $fct_to_call = shift;
 
 wiki_login($wiki_admin, $wiki_admin_pass);
 
-my %functions_to_call = qw(
-       upload_file    wiki_upload_file
-       get_page       wiki_getpage
-       delete_page    wiki_delete_page
-       edit_page      wiki_editpage
-       getallpagename wiki_getallpagename
+my %functions_to_call = (
+       upload_file    => \&wiki_upload_file,
+       get_page       => \&wiki_getpage,
+       delete_page    => \&wiki_delete_page,
+       edit_page      => \&wiki_editpage,
+       getallpagename => \&wiki_getallpagename,
 );
 die "$0 ERROR: wrong argument" unless exists $functions_to_call{$fct_to_call};
-&{$functions_to_call{$fct_to_call}}(@ARGV);
+$functions_to_call{$fct_to_call}->(@ARGV);