]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq: apple: Set .set_boost directly
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 23 Jan 2025 07:44:20 +0000 (13:14 +0530)
committerViresh Kumar <viresh.kumar@linaro.org>
Fri, 7 Feb 2025 04:15:15 +0000 (09:45 +0530)
The boost feature can be controlled at two levels currently, driver
level (applies to all policies) and per-policy.

Currently the driver enables driver level boost support from the
per-policy ->init() callback, which isn't really efficient as that gets
called for each policy and then there is online/offline path too where
this gets done unnecessarily.

Instead set the .set_boost field directly and always enable the boost
support. If a policy doesn't support boost feature, the core will not
enable it for that policy.

Keep the initial state of driver level boost to disabled and let the
user enable it if required as ideally the boost frequencies must be used
only when really required.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
drivers/cpufreq/apple-soc-cpufreq.c

index 6ff604a0fe79b85a5d4029896ab1513d78f3ea4b..4994c86feb5738cdbc80acc740a938540b943df8 100644 (file)
@@ -310,15 +310,6 @@ static int apple_soc_cpufreq_init(struct cpufreq_policy *policy)
        policy->fast_switch_possible = true;
        policy->suspend_freq = freq_table[0].frequency;
 
-       if (policy_has_boost_freq(policy)) {
-               ret = cpufreq_enable_boost_support();
-               if (ret) {
-                       dev_warn(cpu_dev, "failed to enable boost: %d\n", ret);
-               } else {
-                       apple_soc_cpufreq_driver.boost_enabled = true;
-               }
-       }
-
        return 0;
 
 out_free_cpufreq_table:
@@ -353,6 +344,7 @@ static struct cpufreq_driver apple_soc_cpufreq_driver = {
        .target_index   = apple_soc_cpufreq_set_target,
        .fast_switch    = apple_soc_cpufreq_fast_switch,
        .register_em    = cpufreq_register_em_with_opp,
+       .set_boost      = cpufreq_boost_set_sw,
        .suspend        = cpufreq_generic_suspend,
 };