]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
can: rcar_canfd: Invert CAN clock and close_candev() order
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 24 Nov 2025 10:28:30 +0000 (10:28 +0000)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 26 Nov 2025 10:21:55 +0000 (11:21 +0100)
The CAN clock is enabled before calling open_candev(), and disabled
before calling close_candev().  Invert the order of the latter, to
restore symmetry.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://patch.msgid.link/20251124102837.106973-6-biju.das.jz@bp.renesas.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/rcar/rcar_canfd.c

index f18efaf8106162c382c1339f0a34a249c55c80bb..9550f1e74994a362cc26762cc0cd19f136fe5b85 100644 (file)
@@ -1570,8 +1570,8 @@ static int rcar_canfd_close(struct net_device *ndev)
        netif_stop_queue(ndev);
        rcar_canfd_stop(ndev);
        napi_disable(&priv->napi);
-       clk_disable_unprepare(gpriv->can_clk);
        close_candev(ndev);
+       clk_disable_unprepare(gpriv->can_clk);
        phy_power_off(priv->transceiver);
        return 0;
 }