scsi: mpi3mr: Correct a test in mpi3mr_sas_port_add()

The test for a possible shift overflow is not correct. Fix it by replacing
the '>' with a '>='.

Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Link: https://lore.kernel.org/r/20240627074827.13672-1-thenzl@redhat.com
Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c
index 329cc6ec3b589177f5ea1c870e877200ed428be1..ccca28283fa2bf1cc9dca2987358a1b1019abe53 100644 (file)
--- a/drivers/scsi/mpi3mr/mpi3mr_transport.c
+++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c
@@ -1353,7 +1353,7 @@ static struct mpi3mr_sas_port *mpi3mr_sas_port_add(struct mpi3mr_ioc *mrioc,
        mpi3mr_sas_port_sanity_check(mrioc, mr_sas_node,
            mr_sas_port->remote_identify.sas_address, hba_port);
 
-       if (mr_sas_node->num_phys > sizeof(mr_sas_port->phy_mask) * 8)
+       if (mr_sas_node->num_phys >= sizeof(mr_sas_port->phy_mask) * 8)
                ioc_info(mrioc, "max port count %u could be too high\n",
                    mr_sas_node->num_phys);
 
@@ -1363,7 +1363,7 @@ static struct mpi3mr_sas_port *mpi3mr_sas_port_add(struct mpi3mr_ioc *mrioc,
                    (mr_sas_node->phy[i].hba_port != hba_port))
                        continue;
 
-               if (i > sizeof(mr_sas_port->phy_mask) * 8) {
+               if (i >= sizeof(mr_sas_port->phy_mask) * 8) {
                        ioc_warn(mrioc, "skipping port %u, max allowed value is %lu\n",
                            i, sizeof(mr_sas_port->phy_mask) * 8);
                        goto out_fail;