]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
nodedev: refactor udevCCWGetState
authorBoris Fiuczynski <fiuczy@linux.ibm.com>
Tue, 4 Feb 2025 17:11:40 +0000 (18:11 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 5 Feb 2025 16:56:42 +0000 (17:56 +0100)
Refactor method to be only ccw state type depended to allow reuse in a
later patch.

Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/node_device/node_device_udev.c

index 97fbe95ac765c1bbfcfa14c8f0c7b206aaf71620..6b362625f7318e60c59b3f406f493cc063d25036 100644 (file)
@@ -1205,7 +1205,7 @@ udevGetCCWAddress(const char *sysfs_path,
 
 static int
 udevCCWGetState(struct udev_device *device,
-                virNodeDevCapData *data)
+                virNodeDevCCWStateType *state)
 {
     int online = 0;
 
@@ -1215,10 +1215,10 @@ udevCCWGetState(struct udev_device *device,
     switch (online) {
     case VIR_NODE_DEV_CCW_STATE_OFFLINE:
     case VIR_NODE_DEV_CCW_STATE_ONLINE:
-        data->ccw_dev.state = online;
+        *state = online;
         break;
     default:
-        data->ccw_dev.state = VIR_NODE_DEV_CCW_STATE_LAST;
+        *state = VIR_NODE_DEV_CCW_STATE_LAST;
         break;
     }
 
@@ -1231,7 +1231,7 @@ udevProcessCCW(struct udev_device *device,
                virNodeDeviceDef *def)
 {
     /* process only online devices to keep the list sane */
-    if (udevCCWGetState(device, &def->caps->data) < 0)
+    if (udevCCWGetState(device, &def->caps->data.ccw_dev.state) < 0)
         return -1;
 
     if (udevGetCCWAddress(def->sysfs_path, &def->caps->data) < 0)