]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: rockchip: Remove hdmi's 2nd interrupt on rk3328
authorDiederik de Haas <didi.debian@cknow.org>
Tue, 8 Oct 2024 11:15:37 +0000 (13:15 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Tue, 8 Oct 2024 19:17:23 +0000 (21:17 +0200)
The "synopsys,dw-hdmi.yaml" binding specifies that the interrupts
property of the hdmi node has 'maxItems: 1', so the hdmi node in
rk3328.dtsi having 2 is incorrect.

Paragraph 1.3 ("System Interrupt connection") of the RK3328 TRM v1.1
page 16 and 17 define the following hdmi related interrupts:
-  67 hdmi_intr
- 103 hdmi_intr_wakeup

The difference of 32 is due to a different base used in the TRM.

The RK3399 (which uses the same binding) has '23: hdmi_irq' and
'24: hdmi_wakeup_irq' according to its TRM (page 19).
The RK3568 (also same binding) has '76: hdmi_wakeup' and '77: hdmi'
according to page 17 of its TRM.
In both cases the non-wakeup IRQ was used, so use that too for rk3328.

Helped-by: Heiko Stuebner <heiko@sntech.de>
Fixes: 725e351c265a ("arm64: dts: rockchip: add rk3328 display nodes")
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
Link: https://lore.kernel.org/r/20241008113344.23957-3-didi.debian@cknow.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3328.dtsi

index 16b4faa22e4fd949ea33ddaed04c62a0300e7730..c01a4cad48f30eeb4adc16f4ffc68c64cd061705 100644 (file)
                compatible = "rockchip,rk3328-dw-hdmi";
                reg = <0x0 0xff3c0000 0x0 0x20000>;
                reg-io-width = <4>;
-               interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
-                            <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>;
+               interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
                clocks = <&cru PCLK_HDMI>,
                         <&cru SCLK_HDMI_SFC>,
                         <&cru SCLK_RTC32K>;