]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
s390/cpum_sf: Consistently use goto out for function exit
authorThomas Richter <tmricht@linux.ibm.com>
Thu, 24 Oct 2024 11:33:54 +0000 (13:33 +0200)
committerHeiko Carstens <hca@linux.ibm.com>
Tue, 29 Oct 2024 10:17:18 +0000 (11:17 +0100)
When the sampling buffer allocation fails in
__hw_perf_event_init(), jump to the end of the function
and return the result. This is consistent with the other
error handling and return conditions in this function.

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
Reviewed-By: Sumanth Korikkar <sumanthk@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
arch/s390/kernel/perf_cpum_sf.c

index c916d04815db0123bbf079b51d5b221e66f76c56..7a88de52025ca0429c6ab3a911c16ccd13f2b785 100644 (file)
@@ -818,7 +818,7 @@ static int __hw_perf_event_init(struct perf_event *event)
 
        /* Use AUX buffer. No need to allocate it by ourself */
        if (attr->config == PERF_EVENT_CPUM_SF_DIAG)
-               return 0;
+               goto out;
 
        /* Allocate the per-CPU sampling buffer using the CPU information
         * from the event.  If the event is not pinned to a particular