]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: apple: Drop poll for CORE_RC_PHYIF_STAT_REFCLK
authorHector Martin <marcan@marcan.st>
Tue, 1 Apr 2025 09:17:10 +0000 (10:17 +0100)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 23 Apr 2025 07:22:49 +0000 (12:52 +0530)
This is checking a core refclk in per-port setup which doesn't make a
lot of sense, and the bootloader needs to have gone through this anyway.

It doesn't work on T602x, so just drop it across the board.

Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tested-by: Janne Grunau <j@jannau.net>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Acked-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Link: https://patch.msgid.link/20250401091713.2765724-11-maz@kernel.org
drivers/pci/controller/pcie-apple.c

index b8d9b07f35b5139601baa5b04e310bae6097420d..a3ff225d54ce4ee29f4f9082d451533c943ee2f8 100644 (file)
@@ -475,12 +475,6 @@ static int apple_pcie_setup_refclk(struct apple_pcie *pcie,
        u32 stat;
        int res;
 
-       res = readl_relaxed_poll_timeout(pcie->base + CORE_RC_PHYIF_STAT, stat,
-                                        stat & CORE_RC_PHYIF_STAT_REFCLK,
-                                        100, 50000);
-       if (res < 0)
-               return res;
-
        rmw_set(PHY_LANE_CTL_CFGACC, port->phy + PHY_LANE_CTL);
        rmw_set(PHY_LANE_CFG_REFCLK0REQ, port->phy + PHY_LANE_CFG);