BUG/MINOR: tools: fix my_htonll() on x86_64

Commit 36eb3a3 ("MINOR: tools: make my_htonll() more efficient on x86_64")
brought an incorrect asm statement missing the input constraints, causing
the input value not necessarily to be placed into the same register as the
output one, resulting in random output. It happens to work when building at
-O0 but not above. This was only detected in the HTTP/2 parser, but in
mainline it could only affect the integer to binary sample cast.

No backport is needed since this bug was only introduced in the development
branch.

diff --git a/include/common/standard.h b/include/common/standard.h
index 2645c44dd582efb013258537283fa7cbbffd66e9..535efa736303e6a619645320380a1b4b90a25f7d 100644 (file)
--- a/include/common/standard.h
+++ b/include/common/standard.h
@@ -1202,7 +1202,7 @@ static inline unsigned char utf8_return_length(unsigned char code)
 static inline unsigned long long my_htonll(unsigned long long a)
 {
 #if defined(__x86_64__)
-       __asm__ volatile("bswap %0" : "=r"(a));
+       __asm__ volatile("bswap %0" : "=r"(a) : "0"(a));
        return a;
 #else
        union {