]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: mediatek: pwrap: Constify struct pmic_wrapper_type
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 7 Jul 2024 05:47:20 +0000 (07:47 +0200)
committerAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tue, 30 Jul 2024 08:57:19 +0000 (10:57 +0200)
'struct pmic_wrapper_type' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text    data     bss     dec     hex filename
  45336    8724      16   54076    d33c drivers/soc/mediatek/mtk-pmic-wrap.o

After:
=====
   text    data     bss     dec     hex filename
  45528    8532      16   54076    d33c drivers/soc/mediatek/mtk-pmic-wrap.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/5b4b60c5dfd6d8fe893b05cfc96c0e2d67705463.1720331018.git.christophe.jaillet@wanadoo.fr
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
drivers/soc/mediatek/mtk-pmic-wrap.c

index efd9cae212dc64d8a75749aca869b185fc1c2c1b..0da0cdec5050585008549c74ea9fc0735f9c635e 100644 (file)
@@ -2397,7 +2397,7 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
        .init_soc_specific = pwrap_mt8183_init_soc_specific,
 };
 
-static struct pmic_wrapper_type pwrap_mt8195 = {
+static const struct pmic_wrapper_type pwrap_mt8195 = {
        .regs = mt8195_regs,
        .type = PWRAP_MT8195,
        .arb_en_all = 0x777f, /* NEED CONFIRM */
@@ -2423,7 +2423,7 @@ static const struct pmic_wrapper_type pwrap_mt8365 = {
        .init_soc_specific = NULL,
 };
 
-static struct pmic_wrapper_type pwrap_mt8516 = {
+static const struct pmic_wrapper_type pwrap_mt8516 = {
        .regs = mt8516_regs,
        .type = PWRAP_MT8516,
        .arb_en_all = 0xff,
@@ -2435,7 +2435,7 @@ static struct pmic_wrapper_type pwrap_mt8516 = {
        .init_soc_specific = NULL,
 };
 
-static struct pmic_wrapper_type pwrap_mt8186 = {
+static const struct pmic_wrapper_type pwrap_mt8186 = {
        .regs = mt8186_regs,
        .type = PWRAP_MT8186,
        .arb_en_all = 0xfb27f,