]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
leds: bcm63138: Add some register defines
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 10 Oct 2024 14:10:53 +0000 (16:10 +0200)
committerLee Jones <lee@kernel.org>
Fri, 11 Oct 2024 07:37:16 +0000 (08:37 +0100)
The Power LUT (Look-up Table) register base was missing, also
add the bit define for sending serial LED data in reverse order,
and use the BIT() macro to define the bits in the control
register.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20241010-bcm63138-leds-v4-4-cdb80780a555@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/blink/leds-bcm63138.c

index 9fe1af156c80197ded2a90d911fe7ec2c98b432c..ef2e511438ccbf8ca6dee91939bcd6fd94e55830 100644 (file)
 #define BCM63138_LEDS_PER_REG                          (32 / BCM63138_LED_BITS)        /* 8 */
 
 #define BCM63138_GLB_CTRL                              0x00
-#define  BCM63138_GLB_CTRL_SERIAL_LED_DATA_PPOL                0x00000002
-#define  BCM63138_GLB_CTRL_SERIAL_LED_EN_POL           0x00000008
+#define  BCM63138_GLB_CTRL_SERIAL_LED_DATA_PPOL                BIT(1)
+#define  BCM63138_GLB_CTRL_SERIAL_LED_CLK_POL          BIT(2)
+#define  BCM63138_GLB_CTRL_SERIAL_LED_EN_POL           BIT(3)
+#define  BCM63138_GLB_CTRL_SERIAL_LED_MSB_FIRST                BIT(4)
 #define BCM63138_MASK                                  0x04
 #define BCM63138_HW_LED_EN                             0x08
 #define BCM63138_SERIAL_LED_SHIFT_SEL                  0x0c
@@ -35,6 +37,7 @@
 #define BCM63138_BRIGHT_CTRL3                          0x28
 #define BCM63138_BRIGHT_CTRL4                          0x2c
 #define BCM63138_POWER_LED_CFG                         0x30
+#define BCM63138_POWER_LUT_BASE0                       0x34 /* -> b0 */
 #define BCM63138_HW_POLARITY                           0xb4
 #define BCM63138_SW_DATA                               0xb8
 #define BCM63138_SW_POLARITY                           0xbc