]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: usb: scarlett2: Fix missing NULL check
authorTakashi Iwai <tiwai@suse.de>
Thu, 31 Jul 2025 05:37:08 +0000 (07:37 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 31 Jul 2025 15:04:28 +0000 (17:04 +0200)
scarlett2_input_select_ctl_info() sets up the string arrays allocated
via kasprintf(), but it misses NULL checks, which may lead to NULL
dereference Oops.  Let's add the proper NULL check.

Fixes: 8eba063b5b2b ("ALSA: scarlett2: Simplify linked channel handling")
Link: https://patch.msgid.link/20250731053714.29414-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer_scarlett2.c

index 15bbdafc48941e2d786b75671cb2f0f7b3ef3813..1ec203cbbd947292b65e9b71997656819d753d66 100644 (file)
@@ -3978,8 +3978,13 @@ static int scarlett2_input_select_ctl_info(
                goto unlock;
 
        /* Loop through each input */
-       for (i = 0; i < inputs; i++)
+       for (i = 0; i < inputs; i++) {
                values[i] = kasprintf(GFP_KERNEL, "Input %d", i + 1);
+               if (!values[i]) {
+                       err = -ENOMEM;
+                       goto unlock;
+               }
+       }
 
        err = snd_ctl_enum_info(uinfo, 1, i,
                                (const char * const *)values);