]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/edid: make drm_edid_block_valid() static
authorJani Nikula <jani.nikula@intel.com>
Mon, 12 Aug 2024 14:28:49 +0000 (17:28 +0300)
committerJani Nikula <jani.nikula@intel.com>
Wed, 14 Aug 2024 09:16:34 +0000 (12:16 +0300)
drm_edid_block_valid() is no longer used outside of drm_edid.c. Make it
static.

Acked-by: Zhi Wang <zhiwang@kernel.rog>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20240812142849.1588006-2-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/drm_edid.c
include/drm/drm_edid.h

index 9fc7292f5382e1c44f9f4cd02845f856788f88ed..ff1e47a9c83edd7a7a40255e7b242412a24d9211 100644 (file)
@@ -1966,22 +1966,14 @@ static void edid_block_dump(const char *level, const void *block, int block_num)
                       block, EDID_LENGTH, false);
 }
 
-/**
- * drm_edid_block_valid - Sanity check the EDID block (base or extension)
- * @_block: pointer to raw EDID block
- * @block_num: type of block to validate (0 for base, extension otherwise)
- * @print_bad_edid: if true, dump bad EDID blocks to the console
- * @edid_corrupt: if true, the header or checksum is invalid
- *
+/*
  * Validate a base or extension EDID block and optionally dump bad blocks to
  * the console.
- *
- * Return: True if the block is valid, false otherwise.
  */
-bool drm_edid_block_valid(u8 *_block, int block_num, bool print_bad_edid,
-                         bool *edid_corrupt)
+static bool drm_edid_block_valid(void *_block, int block_num, bool print_bad_edid,
+                                bool *edid_corrupt)
 {
-       struct edid *block = (struct edid *)_block;
+       struct edid *block = _block;
        enum edid_block_status status;
        bool is_base_block = block_num == 0;
        bool valid;
@@ -2024,7 +2016,6 @@ bool drm_edid_block_valid(u8 *_block, int block_num, bool print_bad_edid,
 
        return valid;
 }
-EXPORT_SYMBOL(drm_edid_block_valid);
 
 /**
  * drm_edid_is_valid - sanity check EDID data
index 6bdfa254a1c11ed11cf51a0efe73e8e84bf61299..eaac5e665892a0ca8f774c8b6bb23b810545bd9d 100644 (file)
@@ -440,8 +440,6 @@ int drm_add_modes_noedid(struct drm_connector *connector,
                         int hdisplay, int vdisplay);
 
 int drm_edid_header_is_valid(const void *edid);
-bool drm_edid_block_valid(u8 *raw_edid, int block, bool print_bad_edid,
-                         bool *edid_corrupt);
 bool drm_edid_is_valid(struct edid *edid);
 void drm_edid_get_monitor_name(const struct edid *edid, char *name,
                               int buflen);