]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdkfd: remove dead code in the function svm_range_get_pte_flags
authorJesse Zhang <jesse.zhang@amd.com>
Thu, 30 May 2024 02:41:03 +0000 (10:41 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 5 Jun 2024 15:02:59 +0000 (11:02 -0400)
The varible uncached  set false, the condition uncached cannot be true.
So remove the dead code, mapping flags will set the flag AMDGPU_VM_MTYPE_UC in else.

Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdkfd/kfd_svm.c

index 407636a688142f0dfaaa38d5b5989d68d308a252..bd9c2921e0dcccc09a1ef18bb9eda5d54ec6ff34 100644 (file)
@@ -1171,7 +1171,6 @@ svm_range_get_pte_flags(struct kfd_node *node,
        bool snoop = (domain != SVM_RANGE_VRAM_DOMAIN);
        bool coherent = flags & (KFD_IOCTL_SVM_FLAG_COHERENT | KFD_IOCTL_SVM_FLAG_EXT_COHERENT);
        bool ext_coherent = flags & KFD_IOCTL_SVM_FLAG_EXT_COHERENT;
-       bool uncached = false; /*flags & KFD_IOCTL_SVM_FLAG_UNCACHED;*/
        unsigned int mtype_local;
 
        if (domain == SVM_RANGE_VRAM_DOMAIN)
@@ -1220,9 +1219,7 @@ svm_range_get_pte_flags(struct kfd_node *node,
                        mtype_local = amdgpu_mtype_local == 1 ? AMDGPU_VM_MTYPE_NC :
                                amdgpu_mtype_local == 2 ? AMDGPU_VM_MTYPE_CC : AMDGPU_VM_MTYPE_RW;
                snoop = true;
-               if (uncached) {
-                       mapping_flags |= AMDGPU_VM_MTYPE_UC;
-               } else if (domain == SVM_RANGE_VRAM_DOMAIN) {
+               if (domain == SVM_RANGE_VRAM_DOMAIN) {
                        /* local HBM region close to partition */
                        if (bo_node->adev == node->adev &&
                            (!bo_node->xcp || !node->xcp || bo_node->xcp->mem_id == node->xcp->mem_id))