]> git.ipfire.org Git - thirdparty/lldpd.git/commitdiff
client: don't do arithmetics with void*
authorVincent Bernat <vincent@bernat.im>
Tue, 29 Dec 2015 13:47:04 +0000 (14:47 +0100)
committerVincent Bernat <vincent@bernat.im>
Tue, 29 Dec 2015 13:47:04 +0000 (14:47 +0100)
It's illegal.

configure.ac
src/lib/connection.c

index d3bf3c13dc70213bdc2418a57a9cf3a95fcd2be5..3f7dd0ce856b5f8d0ecfa82d4db16b09af666e3b 100644 (file)
@@ -82,6 +82,7 @@ AX_CFLAGS_GCC_OPTION([-Wcast-align], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Wheader-guard], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Wdocumentation], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Winline], [LLDP_CFLAGS])
+AX_CFLAGS_GCC_OPTION([-Wpointer-arith], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-fno-omit-frame-pointer], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Wno-unused-parameter], [LLDP_CFLAGS])
 AX_CFLAGS_GCC_OPTION([-Wno-missing-field-initializers], [LLDP_CFLAGS])
index aeb702e5beb2847b927f2aee3e9b9e9236105622..591d9e9460c5db6cd070e4f5781b68edb8691083 100644 (file)
@@ -77,7 +77,7 @@ sync_recv(lldpctl_conn_t *lldpctl,
 
        remain = length;
        do {
-               if ((nb = read(conn->fd, (void*)data + offset, remain)) == -1) {
+               if ((nb = read(conn->fd, (unsigned char*)data + offset, remain)) == -1) {
                        if (errno == EAGAIN || errno == EINTR)
                                continue;
                        return LLDPCTL_ERR_CALLBACK_FAILURE;