]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.19-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Feb 2022 07:59:28 +0000 (08:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Feb 2022 07:59:28 +0000 (08:59 +0100)
added patches:
tty-n_gsm-fix-proper-link-termination-after-failed-open.patch

queue-4.19/series
queue-4.19/tty-n_gsm-fix-proper-link-termination-after-failed-open.patch [new file with mode: 0644]

index cc5f9ad91816ea75d5b123abb37e761e1a60be85..d600811e888f0cfe62f1baa69006d7a7404434a2 100644 (file)
@@ -13,6 +13,7 @@ drm-edid-always-set-rgb444.patch
 net-mlx5e-fix-wrong-return-value-on-ioctl-eeprom-query-failure.patch
 configfs-fix-a-race-in-configfs_-un-register_subsyst.patch
 rdma-ib_srp-fix-a-deadlock.patch
+tty-n_gsm-fix-proper-link-termination-after-failed-open.patch
 tracing-have-traceon-and-traceoff-trigger-honor-the-instance.patch
 iio-adc-men_z188_adc-fix-a-resource-leak-in-an-error-handling-path.patch
 ata-pata_hpt37x-disable-primary-channel-on-hpt371.patch
diff --git a/queue-4.19/tty-n_gsm-fix-proper-link-termination-after-failed-open.patch b/queue-4.19/tty-n_gsm-fix-proper-link-termination-after-failed-open.patch
new file mode 100644 (file)
index 0000000..5e1c3e1
--- /dev/null
@@ -0,0 +1,38 @@
+From e3b7468f082d106459e86e8dc6fb9bdd65553433 Mon Sep 17 00:00:00 2001
+From: "daniel.starke@siemens.com" <daniel.starke@siemens.com>
+Date: Thu, 17 Feb 2022 23:31:19 -0800
+Subject: tty: n_gsm: fix proper link termination after failed open
+
+From: daniel.starke@siemens.com <daniel.starke@siemens.com>
+
+commit e3b7468f082d106459e86e8dc6fb9bdd65553433 upstream.
+
+Trying to open a DLCI by sending a SABM frame may fail with a timeout.
+The link is closed on the initiator side without informing the responder
+about this event. The responder assumes the link is open after sending a
+UA frame to answer the SABM frame. The link gets stuck in a half open
+state.
+
+This patch fixes this by initiating the proper link termination procedure
+after link setup timeout instead of silently closing it down.
+
+Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
+Cc: stable@vger.kernel.org
+Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
+Link: https://lore.kernel.org/r/20220218073123.2121-3-daniel.starke@siemens.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/tty/n_gsm.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/drivers/tty/n_gsm.c
++++ b/drivers/tty/n_gsm.c
+@@ -1490,7 +1490,7 @@ static void gsm_dlci_t1(struct timer_lis
+                       dlci->mode = DLCI_MODE_ADM;
+                       gsm_dlci_open(dlci);
+               } else {
+-                      gsm_dlci_close(dlci);
++                      gsm_dlci_begin_close(dlci); /* prevent half open link */
+               }
+               break;