Code review for dtrace probes added (so far) to 8.4. Adjust placement of

some bufmgr probes, take out redundant and memory-leak-inducing path arguments
to smgr__md__read__done and smgr__md__write__done, fix bogus attempt to
recalculate space used in sort__done, clean up formatting in places where
I'm not sure pgindent will do a nice job by itself.

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index ca3965b45d78a42a9232f8f48fa63f7278ed3b3f..3027129eb7c1523ee822b3f3981e6d8a60f9457c 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.333 2009/03/04 13:56:40 heikki Exp $
+ * $PostgreSQL: pgsql/src/backend/access/transam/xlog.c,v 1.334 2009/03/11 23:19:24 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -6384,10 +6384,11 @@ CreateCheckPoint(int flags)
        if (log_checkpoints)
                LogCheckpointEnd(false);
 
-        TRACE_POSTGRESQL_CHECKPOINT_DONE(CheckpointStats.ckpt_bufs_written,
-                                NBuffers, CheckpointStats.ckpt_segs_added,
-                                CheckpointStats.ckpt_segs_removed,
-                                CheckpointStats.ckpt_segs_recycled);
+       TRACE_POSTGRESQL_CHECKPOINT_DONE(CheckpointStats.ckpt_bufs_written,
+                                                                        NBuffers,
+                                                                        CheckpointStats.ckpt_segs_added,
+                                                                        CheckpointStats.ckpt_segs_removed,
+                                                                        CheckpointStats.ckpt_segs_recycled);
 
        LWLockRelease(CheckpointLock);
 }

diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 534c7516f78e1030a89b5692bc83ca06dd9e2a49..2c93ad523ab6278e0b760910fbc1a18b3802bf27 100644 (file)
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.245 2009/01/12 05:10:44 tgl Exp $
+ *       $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.246 2009/03/11 23:19:25 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -260,7 +260,11 @@ ReadBuffer_common(SMgrRelation smgr, bool isLocalBuf, ForkNumber forkNum,
        if (isExtend)
                blockNum = smgrnblocks(smgr, forkNum);
 
-       TRACE_POSTGRESQL_BUFFER_READ_START(forkNum, blockNum, smgr->smgr_rnode.spcNode, smgr->smgr_rnode.dbNode, smgr->smgr_rnode.relNode, isLocalBuf);
+       TRACE_POSTGRESQL_BUFFER_READ_START(forkNum, blockNum,
+                                                                          smgr->smgr_rnode.spcNode,
+                                                                          smgr->smgr_rnode.dbNode,
+                                                                          smgr->smgr_rnode.relNode,
+                                                                          isLocalBuf);
 
        if (isLocalBuf)
        {
@@ -269,11 +273,11 @@ ReadBuffer_common(SMgrRelation smgr, bool isLocalBuf, ForkNumber forkNum,
                if (found)
                {
                        LocalBufferHitCount++;
-                       TRACE_POSTGRESQL_BUFFER_HIT(true); /* true == local buffer */
+                       TRACE_POSTGRESQL_BUFFER_HIT(true);              /* true = local buffer */
                }
                else
                {
-                       TRACE_POSTGRESQL_BUFFER_MISS(true); /* ditto */
+                       TRACE_POSTGRESQL_BUFFER_MISS(true);             /* ditto */
                }
        }
        else
@@ -288,11 +292,11 @@ ReadBuffer_common(SMgrRelation smgr, bool isLocalBuf, ForkNumber forkNum,
                if (found)
                {
                        BufferHitCount++;
-                       TRACE_POSTGRESQL_BUFFER_HIT(false); /* false != local buffer */
+                       TRACE_POSTGRESQL_BUFFER_HIT(false);             /* false = shared buffer */
                }
                else
                {
-                       TRACE_POSTGRESQL_BUFFER_MISS(false); /* ditto */
+                       TRACE_POSTGRESQL_BUFFER_MISS(false);    /* ditto */
                }
        }
 
@@ -310,9 +314,11 @@ ReadBuffer_common(SMgrRelation smgr, bool isLocalBuf, ForkNumber forkNum,
                                VacuumCostBalance += VacuumCostPageHit;
 
                        TRACE_POSTGRESQL_BUFFER_READ_DONE(forkNum, blockNum,
-                               smgr->smgr_rnode.spcNode,
-                               smgr->smgr_rnode.dbNode,
-                               smgr->smgr_rnode.relNode, isLocalBuf, found);
+                                                                                         smgr->smgr_rnode.spcNode,
+                                                                                         smgr->smgr_rnode.dbNode,
+                                                                                         smgr->smgr_rnode.relNode,
+                                                                                         isLocalBuf,
+                                                                                         found);
 
                        return BufferDescriptorGetBuffer(bufHdr);
                }
@@ -437,8 +443,11 @@ ReadBuffer_common(SMgrRelation smgr, bool isLocalBuf, ForkNumber forkNum,
                VacuumCostBalance += VacuumCostPageMiss;
 
        TRACE_POSTGRESQL_BUFFER_READ_DONE(forkNum, blockNum,
-                       smgr->smgr_rnode.spcNode, smgr->smgr_rnode.dbNode,
-                       smgr->smgr_rnode.relNode, isLocalBuf, found);
+                                                                         smgr->smgr_rnode.spcNode,
+                                                                         smgr->smgr_rnode.dbNode,
+                                                                         smgr->smgr_rnode.relNode,
+                                                                         isLocalBuf,
+                                                                         found);
 
        return BufferDescriptorGetBuffer(bufHdr);
 }
@@ -582,11 +591,6 @@ BufferAlloc(SMgrRelation smgr, ForkNumber forkNum,
                         * happens to be trying to split the page the first one got from
                         * StrategyGetBuffer.)
                         */
-
-                        TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_START(forkNum,
-                         blockNum, smgr->smgr_rnode.spcNode,
-                         smgr->smgr_rnode.dbNode, smgr->smgr_rnode.relNode);
-
                        if (LWLockConditionalAcquire(buf->content_lock, LW_SHARED))
                        {
                                /*
@@ -607,13 +611,18 @@ BufferAlloc(SMgrRelation smgr, ForkNumber forkNum,
                                }
 
                                /* OK, do the I/O */
+                               TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_START(forkNum, blockNum,
+                                                                                                 smgr->smgr_rnode.spcNode,
+                                                                                                 smgr->smgr_rnode.dbNode,
+                                                                                                 smgr->smgr_rnode.relNode);
+
                                FlushBuffer(buf, NULL);
                                LWLockRelease(buf->content_lock);
 
-                                TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_DONE(
-                                  forkNum, blockNum, smgr->smgr_rnode.spcNode,
-                                  smgr->smgr_rnode.dbNode,
-                                 smgr->smgr_rnode.relNode);
+                               TRACE_POSTGRESQL_BUFFER_WRITE_DIRTY_DONE(forkNum, blockNum,
+                                                                                                        smgr->smgr_rnode.spcNode,
+                                                                                                        smgr->smgr_rnode.dbNode,
+                                                                                                        smgr->smgr_rnode.relNode);
                        }
                        else
                        {
@@ -1235,13 +1244,13 @@ BufferSync(int flags)
                        buf_id = 0;
        }
 
-       TRACE_POSTGRESQL_BUFFER_SYNC_DONE(NBuffers, num_written, num_to_write);
-
        /*
         * Update checkpoint statistics. As noted above, this doesn't include
         * buffers written by other backends or bgwriter scan.
         */
        CheckpointStats.ckpt_bufs_written += num_written;
+
+       TRACE_POSTGRESQL_BUFFER_SYNC_DONE(NBuffers, num_written, num_to_write);
 }
 
 /*
@@ -1852,14 +1861,14 @@ FlushBuffer(volatile BufferDesc *buf, SMgrRelation reln)
        errcontext.previous = error_context_stack;
        error_context_stack = &errcontext;
 
+       TRACE_POSTGRESQL_BUFFER_FLUSH_START(reln->smgr_rnode.spcNode,
+                                                                               reln->smgr_rnode.dbNode,
+                                                                               reln->smgr_rnode.relNode);
+
        /* Find smgr relation for buffer */
        if (reln == NULL)
                reln = smgropen(buf->tag.rnode);
 
-       TRACE_POSTGRESQL_BUFFER_FLUSH_START(reln->smgr_rnode.spcNode,
-                reln->smgr_rnode.dbNode,
-                reln->smgr_rnode.relNode);
-
        /*
         * Force XLOG flush up to buffer's LSN.  This implements the basic WAL
         * rule that log updates must hit disk before any of the data-file changes
@@ -1887,15 +1896,16 @@ FlushBuffer(volatile BufferDesc *buf, SMgrRelation reln)
 
        BufferFlushCount++;
 
-       TRACE_POSTGRESQL_BUFFER_FLUSH_DONE(reln->smgr_rnode.spcNode,
-                reln->smgr_rnode.dbNode, reln->smgr_rnode.relNode);
-
        /*
         * Mark the buffer as clean (unless BM_JUST_DIRTIED has become set) and
         * end the io_in_progress state.
         */
        TerminateBufferIO(buf, true, 0);
 
+       TRACE_POSTGRESQL_BUFFER_FLUSH_DONE(reln->smgr_rnode.spcNode,
+                                                                          reln->smgr_rnode.dbNode,
+                                                                          reln->smgr_rnode.relNode);
+
        /* Pop the error context stack */
        error_context_stack = errcontext.previous;
 }

diff --git a/src/backend/storage/smgr/md.c b/src/backend/storage/smgr/md.c
index 643c75e538b0b2a278a8d22eab84df7d6975ad5b..361d0206797743ba549ab2f71db1fa9e991a2336 100644 (file)
--- a/src/backend/storage/smgr/md.c
+++ b/src/backend/storage/smgr/md.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/storage/smgr/md.c,v 1.144 2009/01/12 05:10:44 tgl Exp $
+ *       $PostgreSQL: pgsql/src/backend/storage/smgr/md.c,v 1.145 2009/03/11 23:19:25 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -581,7 +581,10 @@ mdread(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
        int                     nbytes;
        MdfdVec    *v;
 
-       TRACE_POSTGRESQL_SMGR_MD_READ_START(forknum, blocknum, reln->smgr_rnode.spcNode, reln->smgr_rnode.dbNode, reln->smgr_rnode.relNode);
+       TRACE_POSTGRESQL_SMGR_MD_READ_START(forknum, blocknum,
+                                                                               reln->smgr_rnode.spcNode,
+                                                                               reln->smgr_rnode.dbNode,
+                                                                               reln->smgr_rnode.relNode);
 
        v = _mdfd_getseg(reln, forknum, blocknum, false, EXTENSION_FAIL);
 
@@ -596,7 +599,12 @@ mdread(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
 
        nbytes = FileRead(v->mdfd_vfd, buffer, BLCKSZ);
 
-       TRACE_POSTGRESQL_SMGR_MD_READ_DONE(forknum, blocknum, reln->smgr_rnode.spcNode, reln->smgr_rnode.dbNode, reln->smgr_rnode.relNode, relpath(reln->smgr_rnode, forknum), nbytes, BLCKSZ);
+       TRACE_POSTGRESQL_SMGR_MD_READ_DONE(forknum, blocknum,
+                                                                          reln->smgr_rnode.spcNode,
+                                                                          reln->smgr_rnode.dbNode,
+                                                                          reln->smgr_rnode.relNode,
+                                                                          nbytes,
+                                                                          BLCKSZ);
 
        if (nbytes != BLCKSZ)
        {
@@ -645,7 +653,10 @@ mdwrite(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
        Assert(blocknum < mdnblocks(reln, forknum));
 #endif
 
-       TRACE_POSTGRESQL_SMGR_MD_WRITE_START(forknum, blocknum, reln->smgr_rnode.spcNode, reln->smgr_rnode.dbNode, reln->smgr_rnode.relNode);
+       TRACE_POSTGRESQL_SMGR_MD_WRITE_START(forknum, blocknum,
+                                                                                reln->smgr_rnode.spcNode,
+                                                                                reln->smgr_rnode.dbNode,
+                                                                                reln->smgr_rnode.relNode);
 
        v = _mdfd_getseg(reln, forknum, blocknum, isTemp, EXTENSION_FAIL);
 
@@ -660,7 +671,12 @@ mdwrite(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
 
        nbytes = FileWrite(v->mdfd_vfd, buffer, BLCKSZ);
 
-       TRACE_POSTGRESQL_SMGR_MD_WRITE_DONE(forknum, blocknum, reln->smgr_rnode.spcNode, reln->smgr_rnode.dbNode, reln->smgr_rnode.relNode, relpath(reln->smgr_rnode, forknum), nbytes, BLCKSZ);
+       TRACE_POSTGRESQL_SMGR_MD_WRITE_DONE(forknum, blocknum,
+                                                                               reln->smgr_rnode.spcNode,
+                                                                               reln->smgr_rnode.dbNode,
+                                                                               reln->smgr_rnode.relNode,
+                                                                               nbytes,
+                                                                               BLCKSZ);
 
        if (nbytes != BLCKSZ)
        {

diff --git a/src/backend/utils/probes.d b/src/backend/utils/probes.d
index bec3fb1f3983b6ed6a589cbc2e1d55ec67c66778..18d1b56f5da329582713c19eb16873f824e7e1c4 100644 (file)
--- a/src/backend/utils/probes.d
+++ b/src/backend/utils/probes.d
@@ -3,12 +3,17 @@
  *
  *     Copyright (c) 2006-2009, PostgreSQL Global Development Group
  *
- *     $PostgreSQL: pgsql/src/backend/utils/probes.d,v 1.6 2009/01/01 17:23:48 momjian Exp $
+ *     $PostgreSQL: pgsql/src/backend/utils/probes.d,v 1.7 2009/03/11 23:19:25 tgl Exp $
  * ----------
  */
 
 
-/* typedefs used in PostgreSQL */
+/*
+ * Typedefs used in PostgreSQL.
+ *
+ * NOTE: Do not use system-provided typedefs (e.g. uintptr_t, uint32_t, etc)
+ * in probe definitions, as they cause compilation errors on Mac OS X 10.5.
+ */
 #define LocalTransactionId unsigned int
 #define LWLockId int
 #define LWLockMode int
@@ -20,10 +25,6 @@
 
 provider postgresql {
 
-       /* 
-        * Note: Do not use built-in typedefs (e.g. uintptr_t, uint32_t, etc)            *       as they cause compilation errors in Mac OS X 10.5.  
-        */
-         
        probe transaction__start(LocalTransactionId);
        probe transaction__commit(LocalTransactionId);
        probe transaction__abort(LocalTransactionId);
@@ -51,7 +52,7 @@ provider postgresql {
        probe statement__status(const char *);
 
        probe sort__start(int, bool, int, int, bool);
-       probe sort__done(unsigned long, long);
+       probe sort__done(bool, long);
 
        probe buffer__read__start(ForkNumber, BlockNumber, Oid, Oid, Oid, bool);
        probe buffer__read__done(ForkNumber, BlockNumber, Oid, Oid, Oid, bool, bool);
@@ -83,9 +84,9 @@ provider postgresql {
        probe twophase__checkpoint__done();
 
        probe smgr__md__read__start(ForkNumber, BlockNumber, Oid, Oid, Oid);
-       probe smgr__md__read__done(ForkNumber, BlockNumber, Oid, Oid, Oid, const char *, int, int);
+       probe smgr__md__read__done(ForkNumber, BlockNumber, Oid, Oid, Oid, int, int);
        probe smgr__md__write__start(ForkNumber, BlockNumber, Oid, Oid, Oid);
-       probe smgr__md__write__done(ForkNumber, BlockNumber, Oid, Oid, Oid, const char *, int, int);
+       probe smgr__md__write__done(ForkNumber, BlockNumber, Oid, Oid, Oid, int, int);
 
        probe xlog__insert(unsigned char, unsigned char);
        probe xlog__switch();

diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c
index b6a2c9115e27358f0c42836ec9220140296e33e0..92c55219d32c833af40b5a0ff549dc6803c0e490 100644 (file)
--- a/src/backend/utils/sort/tuplesort.c
+++ b/src/backend/utils/sort/tuplesort.c
@@ -91,7 +91,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/sort/tuplesort.c,v 1.89 2009/01/01 17:23:53 momjian Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/sort/tuplesort.c,v 1.90 2009/03/11 23:19:25 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -117,15 +117,16 @@
 #include "utils/tuplesort.h"
 
 
+/* sort-type codes for sort__start probes */
+#define HEAP_SORT      0
+#define INDEX_SORT     1
+#define DATUM_SORT     2
+
 /* GUC variables */
 #ifdef TRACE_SORT
 bool           trace_sort = false;
 #endif
 
-#define HEAP_SORT      0
-#define INDEX_SORT     1
-#define DATUM_SORT     2
-
 #ifdef DEBUG_BOUNDED_SORT
 bool           optimize_bounded_sort = true;
 #endif
@@ -574,10 +575,14 @@ tuplesort_begin_heap(TupleDesc tupDesc,
                         nkeys, workMem, randomAccess ? 't' : 'f');
 #endif
 
-       TRACE_POSTGRESQL_SORT_START(HEAP_SORT, false, nkeys, workMem, randomAccess);
-
        state->nKeys = nkeys;
 
+       TRACE_POSTGRESQL_SORT_START(HEAP_SORT,
+                                                               false, /* no unique check */
+                                                               nkeys,
+                                                               workMem,
+                                                               randomAccess);
+
        state->comparetup = comparetup_heap;
        state->copytup = copytup_heap;
        state->writetup = writetup_heap;
@@ -642,7 +647,11 @@ tuplesort_begin_index_btree(Relation indexRel,
 
        state->nKeys = RelationGetNumberOfAttributes(indexRel);
 
-       TRACE_POSTGRESQL_SORT_START(INDEX_SORT, enforceUnique, state->nKeys, workMem, randomAccess);
+       TRACE_POSTGRESQL_SORT_START(INDEX_SORT,
+                                                               enforceUnique,
+                                                               state->nKeys,
+                                                               workMem,
+                                                               randomAccess);
 
        state->comparetup = comparetup_index_btree;
        state->copytup = copytup_index;
@@ -715,10 +724,14 @@ tuplesort_begin_datum(Oid datumType,
                         workMem, randomAccess ? 't' : 'f');
 #endif
 
-       TRACE_POSTGRESQL_SORT_START(DATUM_SORT, false, 1, workMem, randomAccess);
-
        state->nKeys = 1;                       /* always a one-column sort */
 
+       TRACE_POSTGRESQL_SORT_START(DATUM_SORT,
+                                                               false, /* no unique check */
+                                                               1,
+                                                               workMem,
+                                                               randomAccess);
+
        state->comparetup = comparetup_datum;
        state->copytup = copytup_datum;
        state->writetup = writetup_datum;
@@ -826,12 +839,16 @@ tuplesort_end(Tuplesortstate *state)
                        elog(LOG, "internal sort ended, %ld KB used: %s",
                                 spaceUsed, pg_rusage_show(&state->ru_start));
        }
-#endif
 
-       TRACE_POSTGRESQL_SORT_DONE(state->tapeset,
-                       (state->tapeset ? LogicalTapeSetBlocks(state->tapeset) :
-                       (state->allowedMem - state->availMem + 1023) / 1024));
+       TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, spaceUsed);
+#else
 
+       /*
+        * If you disabled TRACE_SORT, you can still probe sort__done, but
+        * you ain't getting space-used stats.
+        */
+       TRACE_POSTGRESQL_SORT_DONE(state->tapeset != NULL, 0L);
+#endif
 
        MemoryContextSwitchTo(oldcontext);