net: ti: icssg-prueth: Omit a variable reassignment in prueth_netdev_init()

An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete two redundant variable reassignments.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://patch.msgid.link/71f7daa3-d4f4-4753-aae8-67040fc8297d@web.de
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 1c1f4394ff1f2670b69d5eb0fa284bbe2af297aa..57a7d1ceab088ec61948bc0ffbd4426a7a2b202e 100644 (file)
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1250,8 +1250,7 @@ static int prueth_netdev_init(struct prueth *prueth,
        } else if (of_phy_is_fixed_link(eth_node)) {
                ret = of_phy_register_fixed_link(eth_node);
                if (ret) {
-                       ret = dev_err_probe(prueth->dev, ret,
-                                           "failed to register fixed-link phy\n");
+                       dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n");
                        goto free;
                }
 

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
index 2a8c8847a6bd05e449615a5262cbde7f27d9d4f4..7bb4f0d850cc72d997e5ead38cf56f1dbc2355a1 100644 (file)
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth_sr1.c
@@ -818,8 +818,7 @@ static int prueth_netdev_init(struct prueth *prueth,
        } else if (of_phy_is_fixed_link(eth_node)) {
                ret = of_phy_register_fixed_link(eth_node);
                if (ret) {
-                       ret = dev_err_probe(prueth->dev, ret,
-                                           "failed to register fixed-link phy\n");
+                       dev_err_probe(prueth->dev, ret, "failed to register fixed-link phy\n");
                        goto free;
                }