Bug #1706: Squid time acl accepts invalid time range.

diff --git a/src/ACLTimeData.cc b/src/ACLTimeData.cc
index 8e6f0b451d43bb1b404c6135e3d9cb3b26e673f5..ef8ac5d39526224a7bbb98072a157bb9a9ebba51 100644 (file)
--- a/src/ACLTimeData.cc
+++ b/src/ACLTimeData.cc
@@ -1,5 +1,5 @@
 /*
- * $Id: ACLTimeData.cc,v 1.11 2006/04/23 11:10:31 robertc Exp $
+ * $Id: ACLTimeData.cc,v 1.12 2006/08/26 12:24:12 serassio Exp $
  *
  * DEBUG: section 28    Access Control
  * AUTHOR: Duane Wessels
@@ -190,7 +190,7 @@ ACLTimeData::parse()
         } else {
             /* assume its time-of-day spec */
 
-            if (sscanf(t, "%d:%d-%d:%d", &h1, &m1, &h2, &m2) < 4) {
+            if ((sscanf(t, "%d:%d-%d:%d", &h1, &m1, &h2, &m2) < 4) || (!((h1 >= 0 && h1 < 24) && (h2 >= 0 && h2 < 24) && (m1 >= 0 && m1 < 60) && (m2 >= 0 && m2 < 60)))) {
                 debug(28, 0) ("aclParseTimeSpec: Bad time range '%s'\n", t);
                 self_destruct();