]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fix PR 101453: ICE with optimize and large integer constant
authorAndrew Pinski <apinski@marvell.com>
Fri, 16 Jul 2021 01:07:09 +0000 (18:07 -0700)
committerAndrew Pinski <apinski@marvell.com>
Fri, 16 Jul 2021 18:51:35 +0000 (11:51 -0700)
The problem is the buffer is too small to hold "-O" and
the interger.  This fixes the problem by use the correct size
instead.

Changes since v1:
* v2: Use HOST_BITS_PER_LONG and just divide by 3 instead of
3.32.

OK? Bootstrapped and tested on x86_64-linux with no regressions.

gcc/c-family/ChangeLog:

PR c/101453
* c-common.c (parse_optimize_options): Use the correct
size for buffer.

gcc/c-family/c-common.c

index 681fcc972f4d2e364a69902f72da145bf27565ba..fe3657b9e7404948dba3371947872bc1bf4f10a5 100644 (file)
@@ -5798,7 +5798,7 @@ parse_optimize_options (tree args, bool attr_p)
 
       if (TREE_CODE (value) == INTEGER_CST)
        {
-         char buffer[20];
+         char buffer[HOST_BITS_PER_LONG / 3 + 4];
          sprintf (buffer, "-O%ld", (long) TREE_INT_CST_LOW (value));
          vec_safe_push (optimize_args, ggc_strdup (buffer));
        }