]> git.ipfire.org Git - people/ms/linux.git/commitdiff
extcon: ptn5150: Simplify getting vbus-gpios with flags
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 17 Aug 2020 07:00:02 +0000 (09:00 +0200)
committerChanwoo Choi <cw00.choi@samsung.com>
Thu, 24 Sep 2020 10:20:47 +0000 (19:20 +0900)
Instead of obtaining GPIO as input and configuring it right after to
output-low, just use proper GPIOD_OUT_LOW flag.  Code is smaller and
simpler.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon-ptn5150.c

index 12e52ddbd77e9de4efe8ce8ab7f821c2ec0f3cb1..3b99ad41b06ef19cdd98da2aa69a9c54bbc5141c 100644 (file)
@@ -239,16 +239,11 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
 
        info->dev = &i2c->dev;
        info->i2c = i2c;
-       info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);
+       info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_OUT_LOW);
        if (IS_ERR(info->vbus_gpiod)) {
                dev_err(dev, "failed to get VBUS GPIO\n");
                return PTR_ERR(info->vbus_gpiod);
        }
-       ret = gpiod_direction_output(info->vbus_gpiod, 0);
-       if (ret) {
-               dev_err(dev, "failed to set VBUS GPIO direction\n");
-               return -EINVAL;
-       }
 
        mutex_init(&info->mutex);