mod_skinny parses and modifies odbc url, breaking it, but also doesn't use the result...

Closes: FS-5224 (Thanks to Nathan Neulinger for the patch)

diff --git a/src/mod/endpoints/mod_skinny/mod_skinny.c b/src/mod/endpoints/mod_skinny/mod_skinny.c
index 7026a29c800be24acfc53b3833a7366daad913f5..d20ad5835223a0ee1dc81fa7bf2cdbe06a5202d2 100644 (file)
--- a/src/mod/endpoints/mod_skinny/mod_skinny.c
+++ b/src/mod/endpoints/mod_skinny/mod_skinny.c
@@ -1715,12 +1715,6 @@ switch_status_t skinny_profile_set(skinny_profile_t *profile, const char *var, c
                if (!zstr(val)) {
                        if (switch_odbc_available()) {
                                profile->odbc_dsn = switch_core_strdup(profile->pool, val);
-                               if ((profile->odbc_user = strchr(profile->odbc_dsn, ':'))) {
-                                       *profile->odbc_user++ = '\0';
-                                       if ((profile->odbc_pass = strchr(profile->odbc_user, ':'))) {
-                                               *profile->odbc_pass++ = '\0';
-                                       }
-                               }
                        } else {
                                switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "ODBC IS NOT AVAILABLE!\n");
                        }

diff --git a/src/mod/endpoints/mod_skinny/mod_skinny.h b/src/mod/endpoints/mod_skinny/mod_skinny.h
index 03e0ec0b62fc689dbb14e88a6505d1e715d4601f..d712e044a50cfcb26bf2178d7053f4ddc2321415 100644 (file)
--- a/src/mod/endpoints/mod_skinny/mod_skinny.h
+++ b/src/mod/endpoints/mod_skinny/mod_skinny.h
@@ -90,8 +90,6 @@ struct skinny_profile {
        /* db */
        char *dbname;
        char *odbc_dsn;
-       char *odbc_user;
-       char *odbc_pass;
        switch_odbc_handle_t *master_odbc;
        switch_mutex_t *sql_mutex;      
        /* stats */