]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
firewire: core: annotate fw_destroy_nodes with must-hold-lock
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 15 Sep 2025 23:47:47 +0000 (08:47 +0900)
committerTakashi Sakamoto <o-takashi@sakamocchi.jp>
Mon, 15 Sep 2025 23:52:19 +0000 (08:52 +0900)
The function, fw_destroy_nodes(), is used widely within firewire-core
module. It has a prerequisite condition that struct fw_card.lock must
be hold in advance.

This commit adds annotation for it.

Link: https://lore.kernel.org/r/20250915234747.915922-7-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
drivers/firewire/core-topology.c

index c62cf93f3f65e14e8f43448507a212cc739decc6..8fa0772ee723f4eda4e8818cdd7e68feed1ca9c9 100644 (file)
@@ -325,9 +325,11 @@ static void report_found_node(struct fw_card *card,
        card->bm_retries = 0;
 }
 
-/* Must be called with card->lock held */
 void fw_destroy_nodes(struct fw_card *card)
+__must_hold(&card->lock)
 {
+       lockdep_assert_held(&card->lock);
+
        card->color++;
        if (card->local_node != NULL)
                for_each_fw_node(card, card->local_node, report_lost_node);