drm/tests: hdmi: Add connector disablement test

Atomic check should succeed when disabling a connector. Add a test
case drm_test_check_disabling_connector() to make sure of this.

Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250110084821.3239518-3-victor.liu@nxp.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>

diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
index c3b693bb966f1f8b04066d19f520bfa4bf11c23d..b976a5e9aef58a26a1ef1a8d506010f3639d6c92 100644 (file)
--- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
@@ -1568,6 +1568,57 @@ static void drm_test_check_output_bpc_format_display_8bpc_only(struct kunit *tes
        KUNIT_EXPECT_EQ(test, conn_state->hdmi.output_format, HDMI_COLORSPACE_RGB);
 }
 
+/* Test that atomic check succeeds when disabling a connector. */
+static void drm_test_check_disable_connector(struct kunit *test)
+{
+       struct drm_atomic_helper_connector_hdmi_priv *priv;
+       struct drm_modeset_acquire_ctx *ctx;
+       struct drm_connector_state *conn_state;
+       struct drm_crtc_state *crtc_state;
+       struct drm_atomic_state *state;
+       struct drm_display_mode *preferred;
+       struct drm_connector *conn;
+       struct drm_device *drm;
+       struct drm_crtc *crtc;
+       int ret;
+
+       priv = drm_kunit_helper_connector_hdmi_init(test,
+                                                   BIT(HDMI_COLORSPACE_RGB),
+                                                   8);
+       KUNIT_ASSERT_NOT_NULL(test, priv);
+
+       ctx = drm_kunit_helper_acquire_ctx_alloc(test);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ctx);
+
+       conn = &priv->connector;
+       preferred = find_preferred_mode(conn);
+       KUNIT_ASSERT_NOT_NULL(test, preferred);
+
+       drm = &priv->drm;
+       crtc = priv->crtc;
+       ret = light_up_connector(test, drm, crtc, conn, preferred, ctx);
+       KUNIT_ASSERT_EQ(test, ret, 0);
+
+       state = drm_kunit_helper_atomic_state_alloc(test, drm, ctx);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, state);
+
+       crtc_state = drm_atomic_get_crtc_state(state, crtc);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, crtc_state);
+
+       crtc_state->active = false;
+       ret = drm_atomic_set_mode_for_crtc(crtc_state, NULL);
+       KUNIT_EXPECT_EQ(test, ret, 0);
+
+       conn_state = drm_atomic_get_connector_state(state, conn);
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
+
+       ret = drm_atomic_set_crtc_for_connector(conn_state, NULL);
+       KUNIT_EXPECT_EQ(test, ret, 0);
+
+       ret = drm_atomic_check_only(state);
+       KUNIT_ASSERT_EQ(test, ret, 0);
+}
+
 static struct kunit_case drm_atomic_helper_connector_hdmi_check_tests[] = {
        KUNIT_CASE(drm_test_check_broadcast_rgb_auto_cea_mode),
        KUNIT_CASE(drm_test_check_broadcast_rgb_auto_cea_mode_vic_1),
@@ -1582,6 +1633,7 @@ static struct kunit_case drm_atomic_helper_connector_hdmi_check_tests[] = {
         */
        KUNIT_CASE(drm_test_check_broadcast_rgb_crtc_mode_changed),
        KUNIT_CASE(drm_test_check_broadcast_rgb_crtc_mode_not_changed),
+       KUNIT_CASE(drm_test_check_disable_connector),
        KUNIT_CASE(drm_test_check_hdmi_funcs_reject_rate),
        KUNIT_CASE(drm_test_check_max_tmds_rate_bpc_fallback),
        KUNIT_CASE(drm_test_check_max_tmds_rate_format_fallback),