]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
modpost: refactor do_vmbus_entry()
authorMasahiro Yamada <masahiroy@kernel.org>
Wed, 25 Dec 2024 15:33:36 +0000 (00:33 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Sat, 28 Dec 2024 14:31:03 +0000 (23:31 +0900)
Optimize the size of guid_name[], as it only requires 1 additional byte
for '\0' instead of 2.

Simplify the loop by incrementing the iterator by 1 instead of 2.

Remove the unnecessary TO_NATIVE() call, as the guid is represented as
a byte stream.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
scripts/mod/file2alias.c

index ff263c285977856dea0d06d7b8148d4bac36b8e6..2c7b76d4e8ece5c6e862ff9d84108ac10331b6f8 100644 (file)
@@ -812,15 +812,13 @@ static void do_virtio_entry(struct module *mod, void *symval)
  * Each byte of the guid will be represented by two hex characters
  * in the name.
  */
-
 static void do_vmbus_entry(struct module *mod, void *symval)
 {
-       int i;
        DEF_FIELD_ADDR(symval, hv_vmbus_device_id, guid);
-       char guid_name[(sizeof(*guid) + 1) * 2];
+       char guid_name[sizeof(*guid) * 2 + 1];
 
-       for (i = 0; i < (sizeof(*guid) * 2); i += 2)
-               sprintf(&guid_name[i], "%02x", TO_NATIVE((guid->b)[i/2]));
+       for (int i = 0; i < sizeof(*guid); i++)
+               sprintf(&guid_name[i * 2], "%02x", guid->b[i]);
 
        module_alias_printf(mod, false, "vmbus:%s", guid_name);
 }