]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/vmwgfx: Remove initialization of connector status
authorThomas Zimmermann <tzimmermann@suse.de>
Tue, 5 Nov 2024 13:20:10 +0000 (14:20 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Tue, 3 Dec 2024 10:16:16 +0000 (11:16 +0100)
Remove the connector-status initialization from several of vmwgfx's
functions. It is not required by the driver or DRM helpers.

DRM initializes the connector to unknown status in __drm_connector_init()
and reads the physical status when DRM clients or the user needs the
information, or if it detects/polls a change to the status.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Zack Rusin <zack.rusin@broadcom.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241105132045.471856-1-tzimmermann@suse.de
drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c
drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c

index 39949e0a493f3daa88b1f784c3d0f44f894b0557..f0b42952546791cbacdfb1bac8d1736688a181ef 100644 (file)
@@ -479,7 +479,6 @@ static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
        }
 
        drm_connector_helper_add(connector, &vmw_ldu_connector_helper_funcs);
-       connector->status = vmw_du_connector_detect(connector, true);
 
        ret = drm_encoder_init(dev, encoder, &vmw_legacy_encoder_funcs,
                               DRM_MODE_ENCODER_VIRTUAL, NULL);
index 0f4bfd98480afe0ce116ecba4fa9a37c139ad6cf..32029d80b72bd1314c2a9198ed02c1ef14022a8c 100644 (file)
@@ -868,7 +868,6 @@ static int vmw_sou_init(struct vmw_private *dev_priv, unsigned unit)
        }
 
        drm_connector_helper_add(connector, &vmw_sou_connector_helper_funcs);
-       connector->status = vmw_du_connector_detect(connector, true);
 
        ret = drm_encoder_init(dev, encoder, &vmw_screen_object_encoder_funcs,
                               DRM_MODE_ENCODER_VIRTUAL, NULL);
index 82d18b88f4a7e7aaff2d7123fce1af05754e34d9..114a75069e1c9dc69ab8c84d5728bedca08806bb 100644 (file)
@@ -1593,7 +1593,6 @@ static int vmw_stdu_init(struct vmw_private *dev_priv, unsigned unit)
        }
 
        drm_connector_helper_add(connector, &vmw_stdu_connector_helper_funcs);
-       connector->status = vmw_du_connector_detect(connector, false);
 
        ret = drm_encoder_init(dev, encoder, &vmw_stdu_encoder_funcs,
                               DRM_MODE_ENCODER_VIRTUAL, NULL);