]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
checksrc: verify spaces around equals signs
authorDaniel Stenberg <daniel@haxx.se>
Sat, 9 Sep 2017 09:57:17 +0000 (11:57 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Mon, 11 Sep 2017 07:27:28 +0000 (09:27 +0200)
... as the code style mandates.

lib/checksrc.pl

index b9fa9362f4f07d7c361a099ec96120a7759bb86b..f4ffa1ef38cbfacad061af947ca3a66d40f24931 100755 (executable)
@@ -58,7 +58,9 @@ my %warnings = (
     'OPENCOMMENT'      => 'file ended with a /* comment still "open"',
     'ASTERISKSPACE'    => 'pointer declared with space after asterisk',
     'ASTERISKNOSPACE'  => 'pointer declared without space before asterisk',
-    'ASSIGNWITHINCONDITION'  => 'assignment within conditional expression'
+    'ASSIGNWITHINCONDITION'  => 'assignment within conditional expression',
+    'EQUALSNOSPACE'    => 'equals sign without following space',
+    'NOSPACEEQUALS'    => 'equals sign without preceeding space',
     );
 
 sub readwhitelist {
@@ -526,6 +528,20 @@ sub scanfile {
                           "wrongly placed open brace");
             }
         }
+
+        # check for equals sign without spaces next to it
+        if($nostr =~ /(.*)\=[a-z0-9]/i) {
+            checkwarn("EQUALSNOSPACE",
+                      $line, length($1)+1, $file, $ol,
+                      "no space after equals sign");
+        }
+        # check for equals sign without spaces before it
+        elsif($nostr =~ /(.*)[a-z0-9]\=/i) {
+            checkwarn("NOSPACEEQUALS",
+                      $line, length($1)+1, $file, $ol,
+                      "no space before equals sign");
+        }
+
         $line++;
         $prevl = $ol;
     }