]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
PKCS7_SIGNER_INFO: point out confusing names of digest_enc_alg and enc_digest fields
authorDr. David von Oheimb <dev@ddvo.net>
Fri, 13 Oct 2023 20:30:31 +0000 (22:30 +0200)
committerDr. David von Oheimb <dev@ddvo.net>
Tue, 17 Oct 2023 20:02:16 +0000 (22:02 +0200)
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22390)

include/openssl/pkcs7.h.in

index 127d6afea8870900d8f97dfdc05efe3662673966..57e45dc2fb6d2ccfcbd5881559f79d7904642018 100644 (file)
@@ -60,8 +60,8 @@ typedef struct pkcs7_signer_info_st {
     PKCS7_ISSUER_AND_SERIAL *issuer_and_serial;
     X509_ALGOR *digest_alg;
     STACK_OF(X509_ATTRIBUTE) *auth_attr; /* [ 0 ] */
-    X509_ALGOR *digest_enc_alg;
-    ASN1_OCTET_STRING *enc_digest;
+    X509_ALGOR *digest_enc_alg; /* confusing name, actually used for signing */
+    ASN1_OCTET_STRING *enc_digest; /* confusing name, actually signature */
     STACK_OF(X509_ATTRIBUTE) *unauth_attr; /* [ 1 ] */
     /* The private key to sign with */
     EVP_PKEY *pkey;