]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
Curl_closesocket: avoid using 'conn' if NULL
authorDaniel Stenberg <daniel@haxx.se>
Mon, 14 Nov 2022 10:14:45 +0000 (11:14 +0100)
committerDaniel Stenberg <daniel@haxx.se>
Mon, 14 Nov 2022 13:54:29 +0000 (14:54 +0100)
... in debug-only code.

Reported by Coverity CID 1516896

Closes #9907

lib/connect.c

index 8cb018edc39d6e01d4e99ee478df73430babb4c0..fbb8e86ee4b61d9b8266105590a02466bb5e9c3c 100644 (file)
@@ -1472,8 +1472,9 @@ bool Curl_connalive(struct connectdata *conn)
 int Curl_closesocket(struct Curl_easy *data, struct connectdata *conn,
                      curl_socket_t sock)
 {
-  DEBUGF(infof(data, "Curl_closesocket(conn #%ld, sock=%d), fclosesocket=%d",
-         conn->connection_id, (int)sock, conn->fclosesocket));
+  DEBUGF(infof(data, "Curl_closesocket(conn #%ld, sock=%d), fclosesocket=%p",
+               conn ? conn->connection_id : -1,
+               (int)sock, conn ? conn->fclosesocket : NULL));
   if(conn && conn->fclosesocket) {
     if((sock == conn->sock[SECONDARYSOCKET]) && conn->bits.sock_accepted)
       /* if this socket matches the second socket, and that was created with